From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Dan Murphy <dmurphy@ti.com>, <pavel@ucw.cz>, <robh+dt@kernel.org>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: leds: Update devicetree documents for ID_RGB
Date: Wed, 14 Oct 2020 15:58:54 +0800 [thread overview]
Message-ID: <afc6328e-1f34-8288-b0d2-20328eabf967@huawei.com> (raw)
In-Reply-To: <20201013175034.25911-1-dmurphy@ti.com>
On 2020/10/14 1:50, Dan Murphy wrote:
> Update the leds/common.yaml to indicate that the max color ID is 9.
> Reflect the same change in the leds-class-multicolor.yaml
>
> Reported-by: Zhen Lei <thunder.leizhen@huawei.com>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 2 +-
> .../devicetree/bindings/leds/leds-class-multicolor.yaml | 9 +++++----
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index a2a541bca73c..0c9f912dfee6 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -43,7 +43,7 @@ properties:
> LED_COLOR_ID available, add a new one.
> $ref: /schemas/types.yaml#definitions/uint32
> minimum: 0
> - maximum: 8
> + maximum: 9
>
> function-enumerator:
> description:
> diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> index b55e1f1308a4..f8032e863ecb 100644
> --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> @@ -16,7 +16,7 @@ description: |
> modules. This is achieved by adding multi-led nodes layer to the
> monochrome LED bindings.
> The nodes and properties defined in this document are unique to the multicolor
> - LED class. Common LED nodes and properties are inherited from the common.txt
> + LED class. Common LED nodes and properties are inherited from the common.yaml
> within this documentation directory.
>
> patternProperties:
> @@ -25,10 +25,11 @@ patternProperties:
> description: Represents the LEDs that are to be grouped.
> properties:
> color:
> - const: 8 # LED_COLOR_ID_MULTI
> + const: 9 # LED_COLOR_ID_RGB
This means only LED_COLOR_ID_RGB is allowed.
> description: |
> - For multicolor LED support this property should be defined as
> - LED_COLOR_ID_MULTI which can be found in include/linux/leds/common.h.
> + For multicolor LED support this property should be defined as either
> + LED_COLOR_ID_RGB or LED_COLOR_ID_MULTI which can be found in
If both LED_COLOR_ID_RGB and LED_COLOR_ID_MULTI are allowed, then we should use enum
list both of them.
> + include/linux/leds/common.h.
>
> $ref: "common.yaml#"
>
>
prev parent reply other threads:[~2020-10-14 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 17:50 [PATCH] dt-bindings: leds: Update devicetree documents for ID_RGB Dan Murphy
2020-10-14 7:58 ` Leizhen (ThunderTown) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afc6328e-1f34-8288-b0d2-20328eabf967@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).