From: Thomas Gleixner <tglx@linutronix.de>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
rt@linutronix.de, Richard Cochran <rcochran@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org
Subject: Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine
Date: Thu, 14 Jul 2016 13:33:06 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1607141331390.19117@nanos> (raw)
In-Reply-To: <57877640.4020004@samsung.com>
On Thu, 14 Jul 2016, Jacek Anaszewski wrote:
> On 07/14/2016 11:41 AM, Peter Zijlstra wrote:
> > On Thu, Jul 14, 2016 at 10:10:55AM +0200, Jacek Anaszewski wrote:
> > > On 07/14/2016 09:47 AM, Ingo Molnar wrote:
> > > >
> > > > * Jacek Anaszewski <j.anaszewski@samsung.com> wrote:
> > > >
> > > > > > @@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void)
> > > > > > }
> > > > > >
> > > > > > register_syscore_ops(&ledtrig_cpu_syscore_ops);
> > > > > > - register_cpu_notifier(&ledtrig_cpu_nb);
> > > > > > +
> > > > > > + /*
> > > > > > + * FIXME: Why needs this to happen in the interrupt disabled
> > > > > > + * low level bringup phase of a cpu?
> > > > > > + */
> >
> > > Thanks for the explanation. I'm OK with that approach.
> >
> > Since we have your attention, could you perhaps attempt to answer the
> > question so we can fix the fixme?
> >
>
> This is the way how all led triggers are being registered.
>
> Once a trigger module is loaded it needs to be registered in
> the LED Trigger core.
That does not explain WHY this needs to happen in the low level bringup phase
of the CPU with interrupts disabled and can't be done from the normal ONLINE
callbacks in thread context.
Thanks,
tglx
next prev parent reply other threads:[~2016-07-14 11:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160713153219.128052238@linutronix.de>
2016-07-13 17:16 ` [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine Anna-Maria Gleixner
2016-07-14 7:19 ` Jacek Anaszewski
2016-07-14 7:47 ` Ingo Molnar
2016-07-14 8:10 ` Jacek Anaszewski
2016-07-14 9:41 ` Peter Zijlstra
2016-07-14 11:23 ` Jacek Anaszewski
2016-07-14 11:33 ` Thomas Gleixner [this message]
2016-07-14 11:55 ` Jacek Anaszewski
2016-07-15 14:10 ` Sebastian Andrzej Siewior
2016-07-18 8:26 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1607141331390.19117@nanos \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=j.anaszewski@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=rcochran@linutronix.de \
--cc=rpurdie@rpsys.net \
--cc=rt@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).