From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Alexander Dahl <ada@thorsis.com>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-leds@vger.kernel.org
Subject: Re: [Linux-stm32] [PATCH v7 10/12] ARM: dts: stm32: Fix schema warnings for pwm-leds
Date: Mon, 2 Nov 2020 11:47:08 +0100 [thread overview]
Message-ID: <cba67329-d79d-b474-c4b4-77b19aebe52f@pengutronix.de> (raw)
In-Reply-To: <5231529.NqohY00Rok@ada>
Hello Alexander,
On 10/28/20 8:34 AM, Alexander Dahl wrote:
> Hello Ahmad,
>
> Am Dienstag, 27. Oktober 2020, 11:58:10 CET schrieb Ahmad Fatoum:
>> Hello,
>>
>> On 10/27/20 11:05 AM, Alexander Dahl wrote:
>>> Hello Ahmad,
>>>
>>> thanks for your feedback, comments below.
>>>
>>>>> - led-rgb {
>>>>> + led-controller-2 {
>>>>
>>>> Is a single RGB LED really a controller?
>>>
>>> I just followed the recommendations by Rob here.
>>
>> Do you happen to know if the new multicolor LED support could be used here?
>
> AFAIK not yet. The multicolor class should be ready and it is used by some
> drivers for I²C connected LED controllers, but if I understood Pavel
> correctly, additional work has to be done for a gpio and/or pwm multicolor
> driver. See this thread from August for example:
>
> https://lore.kernel.org/linux-leds/2530787.iFCFyWWcSu@g550jk/
I see. Thanks for the info.
>> I find it unfortunate that the device tree loses information relevant to
>> humans to adhere to a fixed nomenclature. Apparently led-controller isn't
>> even codified in the YAML binding (It's just in the examples). If you
>> respin, please add a comment that this is a single RGB led. I'd prefer to
>> keep the information in the DTB as well though.
>
> The "new" attributes 'function' and 'color' attributes should cover this
> information. IIRC those were introduced sometime before v5.4 and documentation
> is in the leds/common.yaml binding. I don't see it in the scope of this patch
> series, but if we would merge this warning fix first, the information is lost,
> so maybe those attributes should be added before?
Does it? The label already says it's a green LED, but the information that
it's a single physical LED 'bulb' is lost.
>
> My heuristics on that would be looking at the label and if there's a distinct
> color in it, add the color property. I could do that for all pwm LEDs known to
> the tree currently. That would be a bigger task for GPIO leds though. ;-)
I would be ok with just the led-containing node hinting that it's a single RGB led.
Cheers,
Ahmad
>
>>
>>>>> compatible = "pwm-leds";
>>>>>
>>>>> - led-red {
>>>>> + led-2 {
>>>>
>>>> Shouldn't this have been led-1 as well or is the numbering "global" ?
>>>
>>> Also good question. This numbering is for dts only, it usually does
>>> not correspond with LEDs on the board, so it could be numbered per
>>> led-controller as well?
>>
>> I'd prefer that it starts by 1. That way it's aligned with PWM channel
>> ID.
>
> Ack.
>
>>
>> Thanks for fixing the dtschema warnings by the way!
>
> Well, I "introduced" them by converting the leds-pwm binding to yaml (not
> merged yet), so I could as well fix the warnings then? ;-)
>
> Greets
> Alex
>
>>
>> Cheers,
>> Ahmad
>>
>>> Greets
>>> Alex
>>>
>>>>> label = "mc1:red:rgb";
>>>>> pwms = <&leds_pwm 1 1000000 0>;
>>>>> max-brightness = <255>;
>>>>> active-low;
>>>>>
>>>>> };
>>>>>
>>>>> - led-green {
>>>>> + led-3 {
>>>>>
>>>>> label = "mc1:green:rgb";
>>>>> pwms = <&leds_pwm 2 1000000 0>;
>>>>> max-brightness = <255>;
>>>>> active-low;
>>>>>
>>>>> };
>>>>>
>>>>> - led-blue {
>>>>> + led-4 {
>>>>>
>>>>> label = "mc1:blue:rgb";
>>>>> pwms = <&leds_pwm 3 1000000 0>;
>>>>> max-brightness = <255>;
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-11-02 10:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 20:34 [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 01/12] leds: pwm: Remove platform_data support Alexander Dahl
2020-10-07 10:03 ` Pavel Machek
2020-10-05 20:34 ` [PATCH v7 02/12] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
2020-10-07 10:02 ` Pavel Machek
2020-10-07 10:03 ` Krzysztof Kozlowski
2020-10-28 20:39 ` Alexander Dahl
2020-10-29 13:46 ` Russell King - ARM Linux admin
2020-11-25 11:08 ` Pavel Machek
2020-10-05 20:34 ` [PATCH v7 03/12] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
2020-10-06 2:17 ` Jeff LaBundy
2020-10-06 6:34 ` Alexander Dahl
2020-10-06 22:27 ` Rob Herring
2020-10-06 22:28 ` Rob Herring
2020-10-07 10:03 ` Pavel Machek
2020-10-07 10:08 ` Alexander Dahl
2020-10-08 7:33 ` Lee Jones
2020-10-08 7:50 ` Pavel Machek
2020-10-05 20:34 ` [PATCH v7 04/12] ARM: dts: at91: smartkiz: Reference led node directly Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 05/12] ARM: dts: at91: Fix schema warnings for pwm-leds Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 06/12] ARM: dts: berlin: " Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 07/12] ARM: dts: exynos: " Alexander Dahl
2020-10-07 6:25 ` Krzysztof Kozlowski
2020-10-26 18:45 ` Krzysztof Kozlowski
2020-10-05 20:34 ` [PATCH v7 08/12] ARM: dts: imx: " Alexander Dahl
2020-10-30 7:46 ` Shawn Guo
2020-10-05 20:34 ` [PATCH v7 09/12] ARM: dts: omap: " Alexander Dahl
2020-11-10 13:25 ` Tony Lindgren
2020-10-05 20:34 ` [PATCH v7 10/12] ARM: dts: stm32: " Alexander Dahl
2020-10-27 7:03 ` [Linux-stm32] " Ahmad Fatoum
2020-10-27 10:05 ` Alexander Dahl
2020-10-27 10:58 ` Ahmad Fatoum
2020-10-28 7:34 ` Alexander Dahl
2020-11-02 10:47 ` Ahmad Fatoum [this message]
2020-10-05 20:34 ` [PATCH v7 11/12] arm64: dts: meson: " Alexander Dahl
2020-10-05 20:34 ` [PATCH v7 12/12] MIPS: DTS: img: " Alexander Dahl
2020-10-28 18:56 ` [PATCH v7 00/12] leds: pwm: Make automatic labels work Alexandre Belloni
2020-10-28 19:21 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cba67329-d79d-b474-c4b4-77b19aebe52f@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=ada@thorsis.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).