From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
Linux regressions mailing list <regressions@lists.linux.dev>,
Lee Jones <lee@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org,
Miri Korenblit <miriam.rachel.korenblit@intel.com>
Subject: Re: 6.9.0-rc2+ kernel hangs on boot (bisected, maybe LED related)
Date: Wed, 24 Apr 2024 19:31:26 +0200 [thread overview]
Message-ID: <df15843e830d1be0137eb43402a334faf895d2be.camel@sipsolutions.net> (raw)
In-Reply-To: <6eba2967-e2de-d9f1-3794-01cf4e88c56c@candelatech.com>
Hi Ben,
On Wed, 2024-04-24 at 10:26 -0700, Ben Greear wrote:
>
> This patch makes the problem go away in my testbed with 24 Intel
> iwlwifi radios. My guess is that it is just papering over the problem,
Agree, there seems to be some locking issue with LED stuff, but I'm not
sure where, and the driver doesn't even hold any locks here.
> but maybe good enough?
For all I care, yes. We explicitly do this last, from a worker that
holds no locks in the driver ... so it's odd. Looking at the history of
it, it seems that it was originally _nowait(), but then in 3.6 I changed
it because of some backport concerns. Though then I also moved it out of
the locked section.
> Would you like me to submit as official
> patch to linux-wireless?
Sure.
johannes
next prev parent reply other threads:[~2024-04-24 17:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <30f757e3-73c5-5473-c1f8-328bab98fd7d@candelatech.com>
[not found] ` <30819e01-43ce-638f-0cc6-067d6a8d03c7@candelatech.com>
2024-04-03 19:35 ` 6.9.0-rc2+ kernel hangs on boot (bisected, maybe LED related) Ben Greear
2024-04-08 16:35 ` Johannes Berg
2024-04-09 8:47 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-09 8:59 ` Johannes Berg
2024-04-11 7:07 ` Lee Jones
2024-04-15 20:37 ` Ben Greear
2024-04-16 6:17 ` Johannes Berg
2024-04-23 9:00 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-23 9:06 ` Johannes Berg
2024-04-23 9:29 ` Linux regression tracking (Thorsten Leemhuis)
2024-04-24 17:26 ` Ben Greear
2024-04-24 17:31 ` Johannes Berg [this message]
2024-05-02 7:19 ` Lee Jones
2024-05-02 8:30 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-05 5:48 ` Ben Greear
2024-05-05 10:55 ` Tetsuo Handa
2024-05-07 4:21 ` Ben Greear
2024-05-07 8:23 ` Lee Jones
2024-04-16 12:19 ` Lee Jones
2024-05-06 20:00 ` Heiner Kallweit
2024-05-07 4:20 ` Ben Greear
2024-05-07 6:27 ` Heiner Kallweit
2024-05-07 10:58 ` Heiner Kallweit
2024-05-08 5:51 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df15843e830d1be0137eb43402a334faf895d2be.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).