From: Zdenek Kabelac <zkabelac@redhat.com>
To: LVM2 development <lvm-devel@redhat.com>,
Eric Ren <renzhengeek@gmail.com>,
LVM general discussion and development <linux-lvm@redhat.com>,
thornber@redhat.com
Subject: Re: [linux-lvm] [lvm-devel] Aborting. LV mythinpool_tmeta is now incomplete
Date: Thu, 11 Apr 2019 13:21:12 +0200 [thread overview]
Message-ID: <9c0fe4b3-24cb-837c-f8fa-c5b89c5665a4@redhat.com> (raw)
In-Reply-To: <CAKM4Aex11MbzzGrWE=aYF+KM+_o3cOrs6N2n_T5+tSpuu7J=5Q@mail.gmail.com>
Dne 11. 04. 19 v 12:01 Eric Ren napsal(a):
> Hi,
>
> Another error message is:
>
> "Failed to suspend thin snapshot origin ..."
>
> which is in _lv_create_an_lv():
>
> ```
> 7829 } else if (lv_is_thin_volume(lv)) {
> 7830 /* For snapshot, suspend active thin origin first */
...
> is active */
> 7843 if (!update_pool_lv(pool_lv, 0)) {
> 7844 stack;
> 7845 goto revert_new_lv;
> 7846 }
> ```
>
> I don't understand why we need to suspend_lv_origin() and resume_lv_origin()
> in line?
>
> And, what reasons might cause this errors?
Hi
When you take any snapshot (thin or thick) the origin LV is suspend with
fsfreeze operation - so the snapshot is takes with filesystem in 'consistent'
state.
Otherwise without this - you may end-up with fs junk in your device - as the
metadata of the filesystem might have stated in page-cache - and no fsck
utility would be able to figure out what should be correct state of 'fs'
without losing various amount of data in this operation.
Regards
Zdenek
next prev parent reply other threads:[~2019-04-11 11:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 0:27 [linux-lvm] Aborting. LV mythinpool_tmeta is now incomplete Eric Ren
2019-04-11 10:01 ` Eric Ren
2019-04-11 11:21 ` Zdenek Kabelac [this message]
2019-04-11 11:03 ` Zdenek Kabelac
2019-04-11 11:26 ` Eric Ren
2019-04-11 11:32 ` Zdenek Kabelac
2019-04-11 11:49 ` Eric Ren
2019-04-11 12:12 ` Zdenek Kabelac
2019-04-11 13:09 ` Eric Ren
2019-04-11 13:13 ` Zdenek Kabelac
[not found] ` <CAKM4Aez9H=GuRLK0EDJTwpb7j34tCu1aY4dS5_L4saDGERestg@mail.gmail.com>
2019-04-11 17:33 ` Eric Ren
2019-04-12 10:05 ` [linux-lvm] [lvm-devel] " Zdenek Kabelac
2019-04-12 10:42 ` Eric Ren
2019-04-12 13:44 ` [linux-lvm] " Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c0fe4b3-24cb-837c-f8fa-c5b89c5665a4@redhat.com \
--to=zkabelac@redhat.com \
--cc=linux-lvm@redhat.com \
--cc=lvm-devel@redhat.com \
--cc=renzhengeek@gmail.com \
--cc=thornber@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).