From: Guenter Roeck <linux@roeck-us.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Max Staudt <max@enpas.org>, Linux I2C <linux-i2c@vger.kernel.org>,
linux-hwmon@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Jean Delvare <jdelvare@suse.com>,
Linux/m68k <linux-m68k@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH v2 3/4] hwmon/ltc2990: Add platform_data support
Date: Tue, 13 Aug 2019 06:27:52 -0700 [thread overview]
Message-ID: <1aff162f-f548-954c-b9d4-c6207a6c5875@roeck-us.net> (raw)
In-Reply-To: <CAMuHMdXHbjfrdusGB3qvcu1a=W65Ef1-NrvcCv1h9E9uicknLg@mail.gmail.com>
On 8/13/19 1:27 AM, Geert Uytterhoeven wrote:
> Hi Günter,
>
> On Tue, Aug 13, 2019 at 10:02 AM Guenter Roeck <linux@roeck-us.net> wrote:
>> On Tue, Aug 13, 2019 at 01:52:36AM +0200, Max Staudt wrote:
>>> This allows code using i2c_new_device() to specify a measurement mode.
>>>
>>> Signed-off-by: Max Staudt <max@enpas.org>
>>> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> ---
>>> drivers/hwmon/ltc2990.c | 9 +++++++++
>>> include/linux/platform_data/ltc2990.h | 11 +++++++++++
>>> 2 files changed, 20 insertions(+)
>>> create mode 100644 include/linux/platform_data/ltc2990.h
>>>
>>> diff --git a/drivers/hwmon/ltc2990.c b/drivers/hwmon/ltc2990.c
>>> index f9431ad43..f19b9c50c 100644
>>> --- a/drivers/hwmon/ltc2990.c
>>> +++ b/drivers/hwmon/ltc2990.c
>>> @@ -14,6 +14,7 @@
>>> #include <linux/kernel.h>
>>> #include <linux/module.h>
>>> #include <linux/of.h>
>>> +#include <linux/platform_data/ltc2990.h>
>>>
>>> #define LTC2990_STATUS 0x00
>>> #define LTC2990_CONTROL 0x01
>>> @@ -206,6 +207,7 @@ static int ltc2990_i2c_probe(struct i2c_client *i2c,
>>> int ret;
>>> struct device *hwmon_dev;
>>> struct ltc2990_data *data;
>>> + struct ltc2990_platform_data *pdata = dev_get_platdata(&i2c->dev);
>>> struct device_node *of_node = i2c->dev.of_node;
>>>
>>> if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_SMBUS_BYTE_DATA |
>>> @@ -227,6 +229,13 @@ static int ltc2990_i2c_probe(struct i2c_client *i2c,
>>> if (data->mode[0] & ~LTC2990_MODE0_MASK ||
>>> data->mode[1] & ~LTC2990_MODE1_MASK)
>>> return -EINVAL;
>>> + } else if (pdata) {
>>> + data->mode[0] = pdata->meas_mode[0];
>>> + data->mode[1] = pdata->meas_mode[1];
>>> +
>>> + if (data->mode[0] & ~LTC2990_MODE0_MASK ||
>>> + data->mode[1] & ~LTC2990_MODE1_MASK)
>>> + return -EINVAL;
>>
>> I would prefer if the driver was modified to accept device
>> properties, and if those were set using the appropriate
>> fwnode function. Any reason for not doing that ?
>
> That was my first thought as well, but isn't that limited to DT and ACPI
> properties (for now)?
>
tcpm and, for example, the wcove driver don't seem to have a problem using
it, I don't see acpi involved there. Also, the code resides in the core driver
code and is always enabled unless I am missing something. What am I missing ?
Guenter
next prev parent reply other threads:[~2019-08-13 13:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 23:52 [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Max Staudt
2019-08-12 23:52 ` [PATCH v2 2/4] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision Max Staudt
2019-08-13 7:03 ` Geert Uytterhoeven
2019-08-13 9:49 ` Max Staudt
2019-08-14 19:52 ` Wolfram Sang
2019-08-12 23:52 ` [PATCH v2 3/4] hwmon/ltc2990: Add platform_data support Max Staudt
2019-08-13 6:59 ` Geert Uytterhoeven
2019-08-13 8:02 ` Guenter Roeck
2019-08-13 8:27 ` Geert Uytterhoeven
2019-08-13 13:27 ` Guenter Roeck [this message]
2019-08-13 13:32 ` Geert Uytterhoeven
2019-08-13 10:10 ` Max Staudt
2019-08-13 13:24 ` Guenter Roeck
2019-08-13 13:31 ` Max
2019-08-14 18:11 ` Max Staudt
2019-08-12 23:52 ` [PATCH v2 4/4] i2c/busses/i2c-icy: Add platform_data for LTC2990 Max Staudt
2019-08-13 7:04 ` Geert Uytterhoeven
2019-08-13 7:08 ` [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Geert Uytterhoeven
2019-08-13 9:50 ` Max Staudt
2019-08-14 19:47 ` Wolfram Sang
2019-08-14 22:33 ` Max Staudt
2019-08-15 7:12 ` Wolfram Sang
2019-08-15 10:00 ` Max Staudt
2019-08-15 11:48 ` Wolfram Sang
2019-08-15 11:52 ` Max
2019-08-15 12:04 ` Wolfram Sang
2019-08-15 12:10 ` Max Staudt
2019-08-15 12:52 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aff162f-f548-954c-b9d4-c6207a6c5875@roeck-us.net \
--to=linux@roeck-us.net \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=max@enpas.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).