From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=hGEk=3J=vger.kernel.org=linux-m68k-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E1243C2D0DB
	for <linux-m68k@archiver.kernel.org>; Mon, 20 Jan 2020 17:58:39 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id C17D022314
	for <linux-m68k@archiver.kernel.org>; Mon, 20 Jan 2020 17:58:39 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726642AbgATR6j (ORCPT <rfc822;linux-m68k@archiver.kernel.org>);
        Mon, 20 Jan 2020 12:58:39 -0500
Received: from mx2.suse.de ([195.135.220.15]:48638 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726901AbgATR6j (ORCPT <rfc822;linux-m68k@lists.linux-m68k.org>);
        Mon, 20 Jan 2020 12:58:39 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
        by mx2.suse.de (Postfix) with ESMTP id 6B209AD5B;
        Mon, 20 Jan 2020 17:58:37 +0000 (UTC)
Date:   Mon, 20 Jan 2020 09:51:44 -0800
From:   Davidlohr Bueso <dave@stgolabs.net>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Davidlohr Bueso <dbueso@suse.de>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH] lib/rbtree: avoid pointless rb_node alignment
Message-ID: <20200120175144.67625skg6eiprpsa@linux-p48b>
References: <20200110215429.30360-1-dave@stgolabs.net>
 <CAMuHMdXeZvJ0X6Ah2CpLRoQJm+YhxAWBt-rUpxoyfOLTcHp+0g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <CAMuHMdXeZvJ0X6Ah2CpLRoQJm+YhxAWBt-rUpxoyfOLTcHp+0g@mail.gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-m68k-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-m68k.vger.kernel.org>
X-Mailing-List: linux-m68k@vger.kernel.org

On Mon, 20 Jan 2020, Geert Uytterhoeven wrote:

>timerqueue_del() uses rbtree, and
>
>    #define rb_parent(r)   ((struct rb_node *)((r)->__rb_parent_color & ~3))
>
>relies on all objects being 4-byte aligned.  But your patch broke that
>assumption on m68k, where the default alignment is 2-byte.
>
>Andrew: please drop this patch.

Yeah that's too bad. I'll send a patch improving the comment around the alignment
once the patch is dropped.

Thanks,
Davidlohr