From: Andrew Morton <akpm@linux-foundation.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Davidlohr Bueso <dbueso@suse.de>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-m68k <linux-m68k@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] lib/rbtree: avoid pointless rb_node alignment
Date: Tue, 21 Jan 2020 13:04:44 -0800 [thread overview]
Message-ID: <20200121130444.0f5c39dc1ca6ba393084b14b@linux-foundation.org> (raw)
In-Reply-To: <20200120175144.67625skg6eiprpsa@linux-p48b>
On Mon, 20 Jan 2020 09:51:44 -0800 Davidlohr Bueso <dave@stgolabs.net> wrote:
> On Mon, 20 Jan 2020, Geert Uytterhoeven wrote:
>
> >timerqueue_del() uses rbtree, and
> >
> > #define rb_parent(r) ((struct rb_node *)((r)->__rb_parent_color & ~3))
> >
> >relies on all objects being 4-byte aligned. But your patch broke that
> >assumption on m68k, where the default alignment is 2-byte.
> >
> >Andrew: please drop this patch.
>
> Yeah that's too bad. I'll send a patch improving the comment around the alignment
> once the patch is dropped.
Thanks, I'll drop this patch.
prev parent reply other threads:[~2020-01-21 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200110215429.30360-1-dave@stgolabs.net>
2020-01-20 14:39 ` [PATCH] lib/rbtree: avoid pointless rb_node alignment Geert Uytterhoeven
2020-01-20 17:51 ` Davidlohr Bueso
2020-01-21 21:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121130444.0f5c39dc1ca6ba393084b14b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Jason@zx2c4.com \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).