From: Michael Schmitz <schmitzmic@gmail.com>
To: Finn Thain <fthain@linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH RFC] m68k: skip kernel premption if interrupts were disabled
Date: Thu, 28 Mar 2024 11:59:32 +1300 [thread overview]
Message-ID: <728a40f7-c189-461f-bab1-7175388faaa6@gmail.com> (raw)
In-Reply-To: <6f264600-0118-fae7-dc7c-e3407b661d66@linux-m68k.org>
Hi Geert,
On 27/03/24 21:38, Finn Thain wrote:
> On Wed, 27 Mar 2024, Finn Thain wrote:
>
>> On Wed, 27 Mar 2024, Michael Schmitz wrote:
>>
>>> it might be easier for Geert to merge the two patches (or a single one)
>>> on top of his preempt branch if they come in the usual git format.
>> I suppose that would be easier, assuming it doesn't need a lot of rework.
>> Anyway, here's the diff.
>>
>> diff --git a/arch/m68k/mm/motorola.c b/arch/m68k/mm/motorola.c
>> index c1761d309fc6..d0092a3127c0 100644
>> --- a/arch/m68k/mm/motorola.c
>> +++ b/arch/m68k/mm/motorola.c
>> @@ -15,6 +15,7 @@
>> #include <linux/mm.h>
>> #include <linux/swap.h>
>> #include <linux/kernel.h>
>> +#include <linux/preempt.h>
>> #include <linux/string.h>
>> #include <linux/types.h>
>> #include <linux/init.h>
>> @@ -139,10 +140,14 @@ void __init init_pointer_table(void *table, int type)
>>
>> void *get_pointer_table(int type)
>> {
>> - ptable_desc *dp = ptable_list[type].next;
>> - unsigned int mask = list_empty(&ptable_list[type]) ? 0 : PD_MARKBITS(dp);
>> + ptable_desc *dp;
>> + unsigned int mask;
>> unsigned int tmp, off;
>>
>> + preempt_disable();
>> +
>> + dp = ptable_list[type].next;
>> + mask = list_empty(&ptable_list[type]) ? 0 : PD_MARKBITS(dp);
>> /*
>> * For a pointer table for a user process address space, a
>> * table is taken from a page allocated for the purpose. Each
>> @@ -153,9 +158,13 @@ void *get_pointer_table(int type)
>> void *page;
>> ptable_desc *new;
>>
>> + sched_preempt_enable_no_resched();
>> +
>> if (!(page = (void *)get_zeroed_page(GFP_KERNEL)))
>> return NULL;
>>
>> + preempt_disable();
>> +
>> if (type == TABLE_PTE) {
>> /*
>> * m68k doesn't have SPLIT_PTE_PTLOCKS for not having
>> @@ -170,6 +179,7 @@ void *get_pointer_table(int type)
>> PD_MARKBITS(new) = ptable_mask(type) - 1;
>> list_add_tail(new, dp);
>>
>> + sched_preempt_enable_no_resched();
>> return (pmd_t *)page;
>> }
>>
>> @@ -180,6 +190,7 @@ void *get_pointer_table(int type)
>> /* move to end of list */
>> list_move_tail(dp, &ptable_list[type]);
>> }
>> + sched_preempt_enable_no_resched();
>> return page_address(PD_PAGE(dp)) + off;
>> }
>>
>> @@ -190,6 +201,8 @@ int free_pointer_table(void *table, int type)
>> unsigned long page = ptable & PAGE_MASK;
>> unsigned int mask = 1U << ((ptable - page)/ptable_size(type));
>>
>> + preempt_disable();
>> +
>> dp = PD_PTABLE(page);
>> if (PD_MARKBITS (dp) & mask)
>> panic ("table already free!");
>> @@ -203,6 +216,7 @@ int free_pointer_table(void *table, int type)
>> if (type == TABLE_PTE)
>> pagetable_pte_dtor(virt_to_ptdesc((void *)page));
>> free_page (page);
>> + sched_preempt_enable_no_resched();
>> return 1;
>> } else if (ptable_list[type].next != dp) {
>> /*
>> @@ -211,6 +225,7 @@ int free_pointer_table(void *table, int type)
>> */
>> list_move(dp, &ptable_list[type]);
>> }
>> + sched_preempt_enable_no_resched();
>> return 0;
>> }
>>
>>
> For my part,
>
> Signed-off-by: Finn Thain <fthain@linux-m68k.org>
Same for me:
Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
next prev parent reply other threads:[~2024-03-27 22:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 1:48 [PATCH RFC] m68k: skip kernel premption if interrupts were disabled Michael Schmitz
[not found] ` <fcabda73-4b16-ee2c-e993-2bfcf392a26a@linux-m68k.org>
[not found] ` <e89bf618-2fa8-7cbd-16ed-d021a9a7f740@gmail.com>
[not found] ` <948c12e4-e85f-a86c-ae95-a1eb03ca026d@gmail.com>
[not found] ` <40928e38-0de7-75a6-d5f7-8c913155da03@linux-m68k.org>
2024-03-23 6:32 ` Michael Schmitz
2024-03-25 6:41 ` Michael Schmitz
2024-03-25 22:28 ` Finn Thain
2024-03-25 22:31 ` Michael Schmitz
2024-03-26 0:41 ` Finn Thain
2024-03-26 9:58 ` Finn Thain
2024-03-26 19:59 ` Michael Schmitz
2024-03-26 22:03 ` Finn Thain
2024-03-26 22:35 ` Michael Schmitz
2024-03-27 3:50 ` Finn Thain
2024-03-27 6:56 ` Michael Schmitz
2024-03-27 23:29 ` Spinlock debug, was " Finn Thain
[not found] ` <7aee9fd9-1c0e-4874-bb86-e512a7c0caa6@gmail.com>
2024-03-28 2:48 ` Finn Thain
2024-03-28 19:54 ` Michael Schmitz
2024-03-30 2:46 ` Michael Schmitz
2024-03-30 6:23 ` Finn Thain
2024-03-31 6:14 ` Michael Schmitz
2024-03-27 8:38 ` Finn Thain
2024-03-27 22:59 ` Michael Schmitz [this message]
2024-03-27 8:22 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=728a40f7-c189-461f-bab1-7175388faaa6@gmail.com \
--to=schmitzmic@gmail.com \
--cc=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).