From: Finn Thain <fthain@linux-m68k.org>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: geert@linux-m68k.org, linux-block@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
drbd-dev@lists.linbit.com, nbd@other.debian.org,
linux-mtd@lists.infradead.org, axboe@kernel.dk,
philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
christoph.boehmwalder@linbit.com, efremov@linux.com,
josef@toxicpanda.com, tim@cyberelk.net, haris.iqbal@ionos.com,
jinpu.wang@ionos.com, richard@nod.at, miquel.raynal@bootlin.com,
vigneshr@ti.com, mcgrof@kernel.org, hare@suse.de,
damien.lemoal@opensource.wdc.com, johannes.thumshirn@wdc.com,
bvanassche@acm.org, ming.lei@redhat.com, vincent.fu@samsung.com,
shinichiro.kawasaki@wdc.com
Subject: Re: [RFC PATCH 15/18] swim: use init disk helper
Date: Wed, 5 Oct 2022 17:54:48 +1100 (AEDT) [thread overview]
Message-ID: <78eb3d46-de71-a20c-ed5a-efc6ce71f571@linux-m68k.org> (raw)
In-Reply-To: <20221005050027.39591-16-kch@nvidia.com>
On Tue, 4 Oct 2022, Chaitanya Kulkarni wrote:
> Add and use the helper to initialize the common fields of struct gendisk
> such as major, first_minor, minors, disk_name, private_data, and ops.
> This initialization is spread all over the block drivers. This avoids
> code repetation of inialization code of gendisk in current block drivers
> and any future ones.
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
> drivers/block/swim.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/block/swim.c b/drivers/block/swim.c
> index 42b4b6828690..7fa4b2766367 100644
> --- a/drivers/block/swim.c
> +++ b/drivers/block/swim.c
> @@ -835,15 +835,12 @@ static int swim_floppy_init(struct swim_priv *swd)
>
> for (drive = 0; drive < swd->floppy_count; drive++) {
> swd->unit[drive].disk->flags = GENHD_FL_REMOVABLE;
> - swd->unit[drive].disk->major = FLOPPY_MAJOR;
> - swd->unit[drive].disk->first_minor = drive;
> - swd->unit[drive].disk->minors = 1;
> sprintf(swd->unit[drive].disk->disk_name, "fd%d", drive);
> - swd->unit[drive].disk->fops = &floppy_fops;
> swd->unit[drive].disk->flags |= GENHD_FL_NO_PART;
> swd->unit[drive].disk->events = DISK_EVENT_MEDIA_CHANGE;
> swd->unit[drive].disk->private_data = &swd->unit[drive];
> - set_capacity(swd->unit[drive].disk, 2880);
> + init_disk(swd->unit[drive].disk, FLOPPY_MAJOR, drive, 1, 2880,
> + &swd->unit[drive], &floopy_dops);
> err = add_disk(swd->unit[drive].disk);
> if (err)
> goto exit_put_disks;
>
You typo'd the ops struct. By inspection, I'd say your patches 11/18 and
16/18 will not compile either.
next prev parent reply other threads:[~2022-10-05 6:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 5:00 [RFC PATCH 00/18] block: add and use init disk helper Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 01/18] " Chaitanya Kulkarni
2022-10-10 7:59 ` Christoph Hellwig
2022-10-05 5:00 ` [RFC PATCH 02/18] nfblock: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 03/18] amiflop: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 04/18] brd: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 05/18] drbd: " Chaitanya Kulkarni
2022-10-05 10:09 ` Christoph Böhmwalder
2022-10-05 17:24 ` Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 06/18] floppy: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 07/18] loop: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 08/18] n64cart: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 09/18] nbd: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 10/18] pcd: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 11/18] pd: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 12/18] pf: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 13/18] pktcdvd: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 14/18] rnbd-clt: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 15/18] swim: " Chaitanya Kulkarni
2022-10-05 6:54 ` Finn Thain [this message]
2022-10-05 5:00 ` [RFC PATCH 16/18] swim3: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 17/18] z2ram: " Chaitanya Kulkarni
2022-10-05 5:00 ` [RFC PATCH 18/18] ubi: " Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78eb3d46-de71-a20c-ed5a-efc6ce71f571@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=christoph.boehmwalder@linbit.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=drbd-dev@lists.linbit.com \
--cc=efremov@linux.com \
--cc=geert@linux-m68k.org \
--cc=hare@suse.de \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=kch@nvidia.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=nbd@other.debian.org \
--cc=philipp.reisner@linbit.com \
--cc=richard@nod.at \
--cc=shinichiro.kawasaki@wdc.com \
--cc=tim@cyberelk.net \
--cc=vigneshr@ti.com \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).