From: Michael Schmitz <schmitzmic@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Greg Ungerer <gerg@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: RFC: remove set_fs for m68k
Date: Sun, 1 Aug 2021 07:31:52 +1200 [thread overview]
Message-ID: <8884e940-22e8-72a5-e9ec-f9b2628b6ef4@gmail.com> (raw)
In-Reply-To: <e9fb28d4-405a-5cc6-b071-707a2edbce92@gmail.com>
Hi Christoph,
Am 25.07.2021 um 19:36 schrieb Michael Schmitz:
> Hi Christoph,
>
> Am 23.07.2021 um 17:11 schrieb Christoph Hellwig:
>> On Fri, Jul 23, 2021 at 04:00:26PM +1200, Michael Schmitz wrote:
>>>> FYI, I've pushed out a new version - this contains the fix from Andreas
>>>> and drops all these uninlining tweaks as they very obviously cause more
>>>> harm than good for now.
>>>>
>>>> And sorry for the delay, life has been a little busy lately.
>>>
>>> The new version passed two rounds of tests OK - looking good so far.
>>
>> Thanks a lot! I'll wait a bit and will send it out as a formal series.
>
> Just saw this:
>
> [256262.110000] *** FORMAT ERROR *** FORMAT=0
> [256262.140000] Current process id is 2969
> [256262.170000] BAD KERNEL TRAP: 00000000
> [256262.190000] Modules linked in: atari_scsi ne 8390p
> [256262.220000] PC: [<00002a8c>] resume_userspace+0x14/0x16
> [256262.250000] SR: 2200 SP: 4b4338bf a2: 00000000
> [256262.290000] d0: 00000008 d1: 00000003 d2: 00000ba1 d3:
> 00000000
> [256262.300000] d4: ffffffff d5: 00000000 a0: 00000ba1 a1:
> 00000080
> [256262.320000] Process savelog (pid: 2969, task=d81f6132)
> [256262.340000] Frame format=0
> [256262.360000] Stack from 00c1bfa4:
> [256262.360000] 02108005 0d06b008 00000009 00000000 00000001
> 000347ba 0080ab00 00778b6c
> [256262.360000] 00c1be0c 0003e68e 00d11970 00000003 00000000
> 002c7bca 00035a66 00d11970
> [256262.360000] 00778b6c 00809014 00000000 00002700 0000006d
> 00002600 00049ef6
> [256262.470000] Call Trace: [<000347ba>] get_work_pool+0x0/0x38
> [256262.480000] [<0003e68e>] wake_up_process+0x12/0x16
> [256262.500000] [<002c7bca>] printk+0x0/0x18
> [256262.520000] [<00035a66>] __queue_work+0x1a8/0x1be
> [256262.540000] [<00002700>] wait_for_initramfs+0x50/0x58
> [256262.570000] [<00002600>] name_to_dev_t+0x2b0/0x360
> [256262.580000] [<00049ef6>] __irq_wake_thread+0x0/0x40
> [256262.600000]
> [256262.610000] Code: 1029 0007 660c 4cdf 073e 201f 588f dfdf <4e73>
> 254f 040c e308 660a 487a ffe0 60ff 002d 336e 598f 48e7 031e 486f 001c 61ff
>
> Same PC as the one I reported on the 18th. Kernel locked up hard and
> needing a hardware reset this time.
>
> I'll back out the top commit of your series (the one removing set_fs())
> and retest. Again, this may take a few days to show any results.
No further format errors, kernel panics or lockups seen after almost a
week of tests.
That suggests something is wrong with your 'm68k: remove set_fs()' commit.
I'll try adding a get_fc() and warn whenever FC does not match what your
patch expects, maybe that can help to get a clearer picture.
Cheers,
Michael
next prev parent reply other threads:[~2021-07-31 19:32 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 7:01 RFC: remove set_fs for m68k Christoph Hellwig
2021-07-09 7:01 ` [PATCH 1/7] m68k: document that access_ok is broken for !CONFIG_CPU_HAS_ADDRESS_SPACES Christoph Hellwig
2021-07-09 7:01 ` [PATCH 2/7] m68k: use BUILD_BUG for passing invalid sizes to get_user/put_user Christoph Hellwig
2021-07-09 7:01 ` [PATCH 3/7] m68k: remove the inline copy_{from,to}_user variants Christoph Hellwig
2021-07-09 7:01 ` [PATCH 4/7] m68k: remove the err argument to the get_user/put_user assembly helpers Christoph Hellwig
2021-07-09 7:01 ` [PATCH 5/7] m68k: factor the 8-byte lowlevel {get,put}_user code into helpers Christoph Hellwig
2021-07-09 7:01 ` [PATCH 6/7] m68k: provide __{get,put}_kernel_nofault Christoph Hellwig
2021-07-09 7:01 ` [PATCH 7/7] m68k: remove set_fs() Christoph Hellwig
2021-07-11 7:20 ` RFC: remove set_fs for m68k Michael Schmitz
2021-07-12 9:50 ` Christoph Hellwig
2021-07-12 10:20 ` Andreas Schwab
2021-07-12 19:12 ` Michael Schmitz
2021-07-13 5:41 ` Christoph Hellwig
2021-07-13 8:16 ` Michael Schmitz
2021-07-13 8:54 ` Christoph Hellwig
2021-07-14 19:26 ` Michael Schmitz
2021-07-14 20:03 ` Andreas Schwab
2021-07-15 5:44 ` Michael Schmitz
2021-07-16 2:03 ` Michael Schmitz
2021-07-17 5:41 ` Michael Schmitz
2021-07-18 1:14 ` Michael Schmitz
2021-07-21 17:05 ` Christoph Hellwig
2021-07-21 19:20 ` Michael Schmitz
2021-07-23 4:00 ` Michael Schmitz
2021-07-23 5:11 ` Christoph Hellwig
2021-07-25 7:36 ` Michael Schmitz
2021-07-31 19:31 ` Michael Schmitz [this message]
2021-08-06 3:10 ` Michael Schmitz
2021-08-11 9:12 ` Christoph Hellwig
2021-08-12 3:37 ` Michael Schmitz
2021-08-15 7:42 ` Christoph Hellwig
2021-08-15 19:17 ` Michael Schmitz
2021-08-16 6:58 ` Christoph Hellwig
[not found] ` <23f745f2-9086-81fb-3d9e-40ea08a1923@linux-m68k.org>
[not found] ` <20210816075155.GA29187@lst.de>
[not found] ` <d407a2a1-738b-5cd5-c2ed-b7250c5da8ec@gmail.com>
[not found] ` <83571ae-10ae-2919-cde-b6b4a5769c9@linux-m68k.org>
[not found] ` <dc594142-e459-533e-cac2-c7a213cec464@gmail.com>
[not found] ` <f4ab2dcb-6761-c60b-54ce-35d0d017d371@gmail.com>
[not found] ` <d772d22e-a945-3e35-80a2-f4783893bea@linux-m68k.org>
[not found] ` <b2c55280-657b-51c2-065c-3fc93db050b9@gmail.com>
[not found] ` <d7b8f7eb-fc18-c8d-fe3e-dcdf19d3f4b@linux-m68k.org>
[not found] ` <755e55ba-4ce2-b4e4-a628-5abc183a557a@linux-m68k.org>
[not found] ` <b52a10fe-3e4b-5740-d3f8-52bce3bc988@linux-m68k.org>
[not found] ` <31f27da7-be60-8eb-9834-748b653c2246@linux-m68k.org>
2021-09-07 3:28 ` Mainline kernel crashes, was " Finn Thain
2021-09-07 5:53 ` Michael Schmitz
2021-09-07 23:50 ` Finn Thain
2021-09-08 8:54 ` Michael Schmitz
2021-09-09 9:40 ` Finn Thain
2021-09-09 23:29 ` Michael Schmitz
2021-09-09 22:51 ` Finn Thain
2021-09-10 0:03 ` Michael Schmitz
2021-09-12 0:51 ` Finn Thain
2021-09-12 3:55 ` Brad Boyer
2021-09-13 1:27 ` Finn Thain
2021-09-13 3:26 ` Michael Schmitz
2021-09-13 5:22 ` Finn Thain
2021-09-13 7:20 ` Michael Schmitz
2021-09-14 3:13 ` Michael Schmitz
2021-09-15 1:38 ` Finn Thain
2021-09-15 8:37 ` Michael Schmitz
2021-09-16 9:04 ` Finn Thain
2021-09-16 22:28 ` Michael Schmitz
2021-09-21 21:14 ` Michael Schcmitz
2021-08-22 19:33 ` Michael Schmitz
2021-08-23 4:04 ` Michael Schmitz
2021-08-23 17:59 ` Linus Torvalds
2021-08-23 21:31 ` Michael Schmitz
2021-08-23 21:49 ` Linus Torvalds
2021-08-24 8:08 ` Andreas Schwab
2021-08-24 8:44 ` Michael Schmitz
2021-08-24 8:59 ` Andreas Schwab
2021-08-25 7:51 ` Michael Schmitz
2021-08-25 8:44 ` Andreas Schwab
2021-08-25 22:59 ` Michael Schmitz
2021-08-25 23:30 ` Brad Boyer
2021-08-26 7:46 ` Michael Schmitz
2021-08-26 7:45 ` Andreas Schwab
2021-09-14 2:43 ` Michael Schmitz
2021-09-14 15:54 ` Linus Torvalds
2021-09-14 16:28 ` Al Viro
2021-09-14 16:38 ` Linus Torvalds
2021-09-15 1:06 ` Al Viro
2021-07-12 19:04 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8884e940-22e8-72a5-e9ec-f9b2628b6ef4@gmail.com \
--to=schmitzmic@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=hch@lst.de \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schwab@linux-m68k.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).