From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wfhigh8-smtp.messagingengine.com (wfhigh8-smtp.messagingengine.com [64.147.123.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B3FA156999 for ; Wed, 3 Apr 2024 23:57:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.159 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712188666; cv=none; b=eRDAHdny3LYQy/AU5mq6dz9bm/5+56Q0z3JydT6WSs/KVtqEf1P5uti1a3dZj1TZnIq3M5Bk+ZYLKUipYXp2KAvHxfA7AWRr9yczYqd4BnslkwM4yuGlz82c/r36xvBgVdiPUBDTgAEpIjAWe36U57saq5bAjYZtO49XmfSSdg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712188666; c=relaxed/simple; bh=sFxDO+zcW9BeIxLKqoVAM4vcKS408qpmhYpiIyex3fM=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=YxdQfABNqH9jcfT9PWVgx7aFmta71wbvOICn+PLWUM5ON9N3mFgZZwsZ09huCCZeLuMxOUZF2rcDmhKdLsGA/e414YV89CcpY9xiE8wouHvl8qNJWZmq+oZzgqfp9ltKwt98z3LjYuj3INMrKENu10GB3AfVqs/iaLsF9MMf+OE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=none smtp.mailfrom=linux-m68k.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Ly6fWjob; arc=none smtp.client-ip=64.147.123.159 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Ly6fWjob" Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.west.internal (Postfix) with ESMTP id 3336D18000E6; Wed, 3 Apr 2024 19:57:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 03 Apr 2024 19:57:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1712188659; x=1712275059; bh=OELAIjno4nfQgKNkfoFeM6509nD9 yu+wU/USbZIq3mQ=; b=Ly6fWjobE6ZPUlqXWFEtFH/gQIHpoid9rDB98jlyaTJh kk0v1oqGGpUj+C/hZS0ulZ4QUvTqgqCDpFBgENNtyGoua/PvmNqc1nnqdZ9KNmS5 hPjpM12T7AolRLgwAARWy4jdMc516acWWWOPveTAIqDnqhXPi1CKQtMOjEvyo+jH 6/umDSd4MU77Diw6lBfYdVdQjr+XK6mD5w52xsNsVXildfxRfnhdDbfeJyC9L201 JlBcfAj/JxeiEWyZ7LgduHl7/NaA8JGPex6jK17kfIXNnOr1ntkwEXtfJln3nEQL WUgUxhNP9UT1myLjFjZDCNEeMMM2F3/qFRT3jcqbrA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefjedgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevufgjkfhfgggtsehttdertddttddvnecuhfhrohhmpefhihhnnhcu vfhhrghinhcuoehfthhhrghinheslhhinhhugidqmheikehkrdhorhhgqeenucggtffrrg htthgvrhhnpeeiudegheevveduffduudehtdevhefhjefffeeuudejueehffekieeguddu hfefveenucffohhmrghinhepkhgvrhhnvghlrdhorhhgpdhgihhthhhusgdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehfthhhrghi nheslhhinhhugidqmheikehkrdhorhhg X-ME-Proxy: Feedback-ID: i58a146ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Apr 2024 19:57:35 -0400 (EDT) Date: Thu, 4 Apr 2024 10:59:21 +1100 (AEDT) From: Finn Thain To: Andy Shevchenko cc: Greg Kroah-Hartman , Jiri Slaby , Benjamin Herrenschmidt , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood In-Reply-To: Message-ID: <8f234f26-d5e3-66ed-ab0c-86d3c9852b4a@linux-m68k.org> References: Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 4 Apr 2024, Andy Shevchenko wrote: > ... > > First of all, please read this > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#backtraces-in-commit-messages > and amend the commit message accordingly. > Right -- the call chain is described in the commit log message so the backtrace does not add value. And the timestamps, stack dump etc. are irrelevant. > > Cc: Benjamin Herrenschmidt > > Cc: Michael Ellerman > > Cc: Nicholas Piggin > > Cc: Christophe Leroy > > Cc: "Aneesh Kumar K.V" > > Cc: "Naveen N. Rao" > > Cc: linux-m68k@lists.linux-m68k.org > > Second, please move these Cc to be after the '---' line > I thought they were placed above the line for audit (and signing) purposes. There are thousands of Cc lines in the mainline commit messages since v6.8. > > Link: https://github.com/vivier/qemu-m68k/issues/44 > > Link: https://lore.kernel.org/all/1078874617.9746.36.camel@gaston/ > > Missed Fixes tag? > Would this be ok: Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") I have to ask because some reviewers do not like to see a Fixes tag cite that commit. > > Signed-off-by: Finn Thain > > --- > (here is a good location for Cc:) > Documentation/process/submitting-patches.rst indicats that it should be above the "---" separator together with Acked-by etc. Has this convention changed recently? Thanks for your review.