Re: [PATCH] m68k: mm: fix node memblock init

[Angelo Dureghello <angelo.dureghello@timesys.com>]

Hi Mike,

On Mon, Jun 15, 2020 at 8:26 AM Mike Rapoport <rppt@linux.ibm.com> wrote:
>
> Ho Angelo,
>
> On Mon, Jun 15, 2020 at 12:51:19AM +0200, Angelo Dureghello wrote:
> > After pulling 5.7.0 (linux-next merge), mcf5441x mmu boot was
> > hanging silently.
> >
> > memblock_add() seems not appropriate, since using MAX_NUMNODES
> > as node id, while memblock_add_node() sets up memory for node id 0.
> >
> > Signed-off-by: Angelo Dureghello <angelo.dureghello@timesys.com>
>
> The fix is correct, but it is not complete as nommu should be also
> fixed.
> I've updated your patch with nommu fix [1].
>
> [1] https://lore.kernel.org/lkml/20200615062234.GA7882@kernel.org
>

Thanks a lot !
Will try the no-mmu fix also in short.


> > ---
> >  arch/m68k/mm/mcfmmu.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/m68k/mm/mcfmmu.c b/arch/m68k/mm/mcfmmu.c
> > index 29f47923aa46..7d04210d34f0 100644
> > --- a/arch/m68k/mm/mcfmmu.c
> > +++ b/arch/m68k/mm/mcfmmu.c
> > @@ -174,7 +174,7 @@ void __init cf_bootmem_alloc(void)
> >       m68k_memory[0].addr = _rambase;
> >       m68k_memory[0].size = _ramend - _rambase;
> >
> > -     memblock_add(m68k_memory[0].addr, m68k_memory[0].size);
> > +     memblock_add_node(m68k_memory[0].addr, m68k_memory[0].size, 0);
> >
> >       /* compute total pages in system */
> >       num_pages = PFN_DOWN(_ramend - _rambase);
> > --
> > 2.26.2
> >
>
> --
> Sincerely yours,
> Mike.

Regards,
angelo