From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: linux-m68k <linux-m68k@lists.linux-m68k.org>,
Greg Ungerer <gerg@linux-m68k.org>,
Kees Cook <keescook@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m68k/mm: Stop printing the virtual memory layout
Date: Tue, 13 Feb 2018 08:34:37 +0100 [thread overview]
Message-ID: <CAMuHMdXjUCR0CxNiF7quz0dmM3K_6ocMJ0-mwBi4Y5KbFY=3FQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.21.1802131143320.8@nippy.intranet>
Hi Finn,
On Tue, Feb 13, 2018 at 1:48 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> On Mon, 12 Feb 2018, Geert Uytterhoeven wrote:
>> Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with
>> %p"), the virtual memory layout printed during boot up contains "ptrval"
>> instead of actual addresses:
>>
>> Memory: 268040K/276480K available (2979K kernel code, 310K rwdata, 784K rodata, 144K init, 172K bss, 8440K reserved, 0K cma-reserved)
>> Virtual kernel memory layout:
>> vector : 0x003d2e74 - 0x003d3274 ( 1 KiB)
>> kmap : 0xd0000000 - 0xf0000000 ( 512 MiB)
>> vmalloc : 0x11800000 - 0xd0000000 (3048 MiB)
>> lowmem : 0x00000000 - 0x11000000 ( 272 MiB)
>> .init : 0x(ptrval) - 0x(ptrval) ( 144 KiB)
>> .text : 0x(ptrval) - 0x(ptrval) (2980 KiB)
>> .data : 0x(ptrval) - 0x(ptrval) (1095 KiB)
>> .bss : 0x(ptrval) - 0x(ptrval) ( 173 KiB)
>>
>> Instead of changing the printing to "%px", and leaking virtual memory
>> layout information again,
>>
>> just remove the printing completely, cfr. e.g.
>> commit 071929dbdd865f77 ("arm64: Stop printing the virtual memory
>> layout").
>>
>> All interesting information (actual section sizes) is already printed by
>> mem_init_print_info() just above anyway.
>
> Or maybe revert to %lx with pr_debug instead of pr_notice. Just a thought;
(%px prints unhashed pointers, no need for %lx and cast)
> I don't have any preference.
Dynamic debug is hot these days, so that may be enabled by distros,
still leaking the info.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-02-13 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1518425633-19803-1-git-send-email-geert@linux-m68k.org>
2018-02-13 0:48 ` [PATCH] m68k/mm: Stop printing the virtual memory layout Finn Thain
2018-02-13 7:34 ` Geert Uytterhoeven [this message]
2018-02-12 8:53 Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXjUCR0CxNiF7quz0dmM3K_6ocMJ0-mwBi4Y5KbFY=3FQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=fthain@telegraphics.com.au \
--cc=gerg@linux-m68k.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).