From: Greg Ungerer <gerg@linux-m68k.org>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: linux-m68k@lists.linux-m68k.org, uclinux-dev@uclinux.org
Subject: Re: [PATCH] m68k/nommu: prevent setting ROMKERNEL when ROM is not set
Date: Thu, 8 Jul 2021 22:33:22 +1000 [thread overview]
Message-ID: <a429671e-927e-e5c8-cc33-ab4310446792@linux-m68k.org> (raw)
In-Reply-To: <20210707163729.30388-1-rdunlap@infradead.org>
Hi Randy,
On 8/7/21 2:37 am, Randy Dunlap wrote:
> When CONFIG_ROMKERNEL is set but CONFIG_ROM is not set, the linker
> complains:
> m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:5: undefined symbol `CONFIG_ROMSTART' referenced in expression
>
> # CONFIG_ROM is not set
> # CONFIG_RAMKERNEL is not set
> CONFIG_ROMKERNEL=y
>
> Since ROMSTART depends on ROM, make ROMKERNEL also depend on ROM.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Greg Ungerer <gerg@linux-m68k.org>
> Cc: linux-m68k@lists.linux-m68k.org
> Cc: uclinux-dev@uclinux.org
Looks good, thanks.
I will apply to for-next branch of m68knommu git tree when the current
merge window closes.
Regards
Greg
> ---
> arch/m68k/Kconfig.machine | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20210701.orig/arch/m68k/Kconfig.machine
> +++ linux-next-20210701/arch/m68k/Kconfig.machine
> @@ -464,6 +464,7 @@ config RAMKERNEL
>
> config ROMKERNEL
> bool "ROM"
> + depends on ROM
> help
> The kernel will be resident in FLASH/ROM when running. This is
> often referred to as Execute-in-Place (XIP), since the kernel
>
prev parent reply other threads:[~2021-07-08 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 16:37 [PATCH] m68k/nommu: prevent setting ROMKERNEL when ROM is not set Randy Dunlap
2021-07-08 12:33 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a429671e-927e-e5c8-cc33-ab4310446792@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=rdunlap@infradead.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).