From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware Date: Tue, 12 Jun 2018 09:47:06 +1000 (AEST) Message-ID: References: <9f015684-4d91-70e4-d2a4-89fe167ff8ab@gmail.com> <3490f7d6f45ec2586858e4547e97474d93bd2d4d.camel@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <3490f7d6f45ec2586858e4547e97474d93bd2d4d.camel@kernel.crashing.org> Sender: linux-kernel-owner@vger.kernel.org To: Benjamin Herrenschmidt Cc: Michael Schmitz , Andreas Schwab , linuxppc-dev@lists.ozlabs.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Laurent Vivier List-Id: linux-m68k@vger.kernel.org On Sun, 10 Jun 2018, Benjamin Herrenschmidt wrote: > Pre-PCI is basically "NUBUS" based even in absence of an actual NuBus > slot :-) It has to do with the internal HW architecture. The only ones > that aren't are the even older designs (the 68000 based ones). > There is already some disagreement in the comments in the nubus-pmac code about the suitability of "PMU_NUBUS_BASED" as opposed to e.g. "PMU_WHITNEY_BASED". Point is, the PMU driver doesn't care about the expansion slots or architecture (Whitney-based PMU appears on m68k and powerpc). So NuBus vs. PCI is a red herring here. The pmu_kind relates to backlight, buttons and battery. (Leaving aside the PMU driver, if a pre-OpenFirmware Mac has a "slot zero" ROM, one can argue that it is actually a NuBus machine, regardless of any actual expansion slots.) > What's the situation with those NuBus things ? What do they use as a > bootloader ? The old Apple one or BootX ? We should merge that port of > it's maintained. > I agree that this code should not languish out-of-tree. But it would need more work before it could reasonably be submitted to reviewers. I do have some nubus-pmac hardware but I also have more mac/68k driver work to do before I can tackle another architecture. I don't know what the bootloader situation is, but it looks messy... http://nubus-pmac.sourceforge.net/#booters Laurent, does Emile work on these machines? -- > Cheers, > Ben. >