From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Li Xinhai <lixinhai.lxh@gmail.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Hugh Dickins <hughd@google.com>,
linux-man <linux-man@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] mm: Check range first in queue_pages_test_walk
Date: Thu, 14 Nov 2019 09:35:41 +0000 [thread overview]
Message-ID: <20191114093541.GB2144@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <1573218104-11021-2-git-send-email-lixinhai.lxh@gmail.com>
On Fri, Nov 08, 2019 at 09:01:43PM +0800, Li Xinhai wrote:
> Checking unmapped hole and updating the previous vma must be handled first,
> otherwise the unmapped hole could be calculated from a wrong previous vma.
>
> Several commits were relevant to this error:
> commit 6f4576e3687b
> ("mempolicy: apply page table walker on queue_pages_range()"),
> This commit was correct, the VM_PFNMAP check was after updateing previous
> vma
>
> commit 48684a65b4e3
> (mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)),
> This commit added VM_PFNMAP check before updateing previous vma. Then,
> there were two VM_PFNMAP check did same thing twice.
>
> commit acda0c334028
> (mm/mempolicy.c: get rid of duplicated check for vma(VM_PFNMAP) in queue_page
> s_range()),
> This commit tried to fix the duplicated VM_PFNMAP check, but it wrongly
> removed the one which was after updateing vma.
>
> Fixes: acda0c334028 (mm/mempolicy.c: get rid of duplicated check for vma(VM_PFNMAP) in queue_page
> s_range())
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: linux-man <linux-man@vger.kernel.org>
> Signed-off-by: Li Xinhai <lixinhai.lxh@gmail.com>
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
next prev parent reply other threads:[~2019-11-14 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1573218104-11021-1-git-send-email-lixinhai.lxh@gmail.com>
2019-11-08 13:01 ` [PATCH v4 1/2] mm: Check range first in queue_pages_test_walk Li Xinhai
2019-11-14 9:35 ` Naoya Horiguchi [this message]
2019-11-08 13:01 ` [PATCH v4 2/2] mm: Fix checking unmapped holes for mbind Li Xinhai
2019-11-14 9:30 ` Naoya Horiguchi
2019-11-15 15:33 ` lixinhai.lxh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114093541.GB2144@hori.linux.bs1.fc.nec.co.jp \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lixinhai.lxh@gmail.com \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).