From: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>,
linux-man@vger.kernel.org, linux-api@vger.kernel.org,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Jiri Olsa <jolsa@redhat.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sched_getattr.2: update to include changed size semantics
Date: Thu, 28 Nov 2019 10:08:40 -0300 [thread overview]
Message-ID: <20191128130840.GA3719@calabresa> (raw)
In-Reply-To: <20191128120140.20367-1-cyphar@cyphar.com>
On Thu, Nov 28, 2019 at 11:01:40PM +1100, Aleksa Sarai wrote:
> Due to a userspace breakage, commit 1251201c0d34 ("sched/core: Fix
> uclamp ABI bug, clean up and robustify sched_read_attr() ABI logic and
> code") changed the semantics of sched_getattr(2) when the userspace
> struct is smaller than the kernel struct. Now, any trailing non-zero
> data in the kernel structure is ignored when copying to userspace.
>
> Ref: 1251201c0d34 ("sched/core: Fix uclamp ABI bug, clean up and
> robustify sched_read_attr() ABI logic and code")
> Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> ---
> man2/sched_setattr.2 | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/man2/sched_setattr.2 b/man2/sched_setattr.2
> index 76ffa14eba85..fbb67b8eb98b 100644
> --- a/man2/sched_setattr.2
> +++ b/man2/sched_setattr.2
> @@ -284,10 +284,8 @@ structure,
> the additional bytes in the user-space structure are not touched.
> If the caller-provided structure is smaller than the kernel
> .I sched_attr
> -structure and the kernel needs to return values outside the provided space,
> -.BR sched_getattr ()
> -fails with the error
> -.BR E2BIG .
> +structure, the kernel will silently not return any values which would be stored
> +outside the provided space.
> As with
> .BR sched_setattr (),
> these semantics allow for future extensibility of the interface.
> --
> 2.24.0
>
I was thinking about documenting the difference in behavior of older kernels,
before uclamp support.
However, in practice, for sched_getattr, the kernel never returned E2BIG (the
code uses EFBIG incorrectly, in fact). It does, however, return EINVAL for
sizes smaller than SCHED_ATTR_SIZE_VER0.
The EINVAL return is already well documented in the manpage.
However, E2BIG is still mentioned below as a possible return value for
sched_getattr. Can you remove that too?
Thanks.
Cascardo.
next prev parent reply other threads:[~2019-11-28 13:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 12:01 [PATCH] sched_getattr.2: update to include changed size semantics Aleksa Sarai
2019-11-28 13:08 ` Thadeu Lima de Souza Cascardo [this message]
2019-11-28 13:55 ` Aleksa Sarai
2020-04-25 19:12 ` Michael Kerrisk (man-pages)
2020-05-15 12:10 ` Michael Kerrisk (man-pages)
2020-09-29 22:35 ` [PATCH 1/2] " Aleksa Sarai
2020-09-29 22:35 ` [PATCH 2/2] openat2.2: fix minor reference typo Aleksa Sarai
2020-09-30 10:51 ` Michael Kerrisk (man-pages)
2020-09-30 10:51 ` [PATCH 1/2] sched_getattr.2: update to include changed size semantics Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128130840.GA3719@calabresa \
--to=cascardo@canonical.com \
--cc=acme@infradead.org \
--cc=cyphar@cyphar.com \
--cc=jolsa@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).