From: Aleksa Sarai <cyphar@cyphar.com>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <christian@brauner.io>,
Aleksa Sarai <asarai@suse.de>,
linux-man@vger.kernel.org, linux-api@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH man-pages v2 2/2] openat2.2: document new openat2(2) syscall
Date: Mon, 30 Mar 2020 20:48:36 +1100 [thread overview]
Message-ID: <20200330094836.lhcipdujroahiu4y@yavin.dot.cyphar.com> (raw)
In-Reply-To: <ae275f67-9277-547c-e78c-bca4f388f694@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2304 bytes --]
On 2020-03-30, Michael Kerrisk (man-pages) <mtk.manpages@gmail.com> wrote:
> On 3/30/20 11:20 AM, Aleksa Sarai wrote:
> > On 2020-03-30, Michael Kerrisk (man-pages) <mtk.manpages@gmail.com> wrote:
> >> Hello Aleksa,
> >>
> >> On 2/2/20 4:19 PM, Aleksa Sarai wrote:
> >>> Rather than trying to merge the new syscall documentation into open.2
> >>> (which would probably result in the man-page being incomprehensible),
> >>> instead the new syscall gets its own dedicated page with links between
> >>> open(2) and openat2(2) to avoid duplicating information such as the list
> >>> of O_* flags or common errors.
> >>>
> >>> In addition to describing all of the key flags, information about the
> >>> extensibility design is provided so that users can better understand why
> >>> they need to pass sizeof(struct open_how) and how their programs will
> >>> work across kernels. After some discussions with David Laight, I also
> >>> included explicit instructions to zero the structure to avoid issues
> >>> when recompiling with new headers.>
> >>> Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> >>
> >> I'm just editing this page, and have a question on one piece.
> >>
> >>> +Unlike
> >>> +.BR openat (2),
> >>> +it is an error to provide
> >>> +.BR openat2 ()
> >>> +with a
> >>> +.I mode
> >>> +which contains bits other than
> >>> +.IR 0777 ,
> >>
> >> This piece appears not to be true, both from my reading of the
> >> source code, and from testing (i.e., I wrote a a small program that
> >> successfully called openat2() and created a file that had the
> >> set-UID, set-GID, and sticky bits set).
> >>
> >> Is this a bug in the implementation or a bug in the manual page text?
> >
> > My bad -- it's a bug in the manual. The actual check (which does work,
> > there are selftests for this) is:
> >
> > if (how->mode & ~S_IALLUGO)
> > return -EINVAL;
> >
> > But when writing the man page I forgot that S_IALLUGO also includes
> > those bits. Do you want me to send an updated version or would you
> > prefer to clean it up?
>
> I'll clean it up.
>
> So, it should say, "bits other than 07777", right?
Yes, that would be correct.
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-03-30 9:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 15:19 [PATCH man-pages v2 0/2] document openat2(2) Aleksa Sarai
2020-02-02 15:19 ` [PATCH man-pages v2 1/2] path_resolution.7: update to mention openat2(2) features Aleksa Sarai
2020-03-30 20:38 ` Michael Kerrisk (man-pages)
2020-02-02 15:19 ` [PATCH man-pages v2 2/2] openat2.2: document new openat2(2) syscall Aleksa Sarai
2020-03-30 9:08 ` Michael Kerrisk (man-pages)
2020-03-30 9:20 ` Aleksa Sarai
2020-03-30 9:36 ` Michael Kerrisk (man-pages)
2020-03-30 9:48 ` Aleksa Sarai [this message]
2020-03-30 20:43 ` Michael Kerrisk (man-pages)
2020-03-31 14:39 ` Aleksa Sarai
2020-04-01 6:38 ` Michael Kerrisk (man-pages)
2020-04-08 21:29 ` Michael Kerrisk (man-pages)
2020-04-12 16:49 ` Aleksa Sarai
2020-04-13 7:22 ` Michael Kerrisk (man-pages)
2020-04-14 10:35 ` Aleksa Sarai
2020-04-15 20:24 ` Michael Kerrisk (man-pages)
2020-05-04 10:17 ` Michael Kerrisk (man-pages)
2020-06-10 5:53 ` [PATCH] symlink.7: document magic-links more completely Aleksa Sarai
2020-06-19 13:00 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330094836.lhcipdujroahiu4y@yavin.dot.cyphar.com \
--to=cyphar@cyphar.com \
--cc=asarai@suse.de \
--cc=christian@brauner.io \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).