From: "Darrick J. Wong" <djwong@kernel.org>
To: Dan Robertson <dan@dlrobertson.com>
Cc: linux-man@vger.kernel.org, alx.manpages@gmail.com,
mtk.manpages@gmail.com
Subject: Re: [PATCH 1/1] man2/fallocate.2: tfix documentation of shared blocks
Date: Sun, 20 Jun 2021 21:25:50 -0700 [thread overview]
Message-ID: <20210621042550.GG158232@locust> (raw)
In-Reply-To: <20210621004453.7437-2-dan@dlrobertson.com>
On Sun, Jun 20, 2021 at 08:44:53PM -0400, Dan Robertson wrote:
> Fix a typo in the documentation of using fallocate to allocate shared
> blocks. The flag FALLOC_FL_UNSHARE should instead be documented as
> FALLOC_FL_UNSHARE_RANGE.
>
> Fixes: 07c7a6a35497 ("man2/fallocate.2: Document behavior with shared blocks")
> Signed-off-by: Dan Robertson <dan@dlrobertson.com>
Definitely an artifact of unshare being added and removed repeatedly
during the development of XFS reflink. Thanks for fixing this...
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> man2/fallocate.2 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man2/fallocate.2 b/man2/fallocate.2
> index a62706193..b4cb3516f 100644
> --- a/man2/fallocate.2
> +++ b/man2/fallocate.2
> @@ -81,7 +81,7 @@ Preallocating zeroed blocks beyond the end of the file in this manner
> is useful for optimizing append workloads.
> .PP
> If the
> -.B FALLOC_FL_UNSHARE
> +.B FALLOC_FL_UNSHARE_RANGE
> flag is specified in
> .IR mode ,
> shared file data extents will be made private to the file to guarantee
next prev parent reply other threads:[~2021-06-21 4:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 0:44 [PATCH 0/1] man2/fallocate.2: Fix documentation of shared blocks Dan Robertson
2021-06-21 0:44 ` [PATCH 1/1] man2/fallocate.2: tfix " Dan Robertson
2021-06-21 4:25 ` Darrick J. Wong [this message]
2021-06-28 13:13 ` Dan Robertson
2021-07-03 18:20 ` Alejandro Colomar (man-pages)
2021-07-03 18:26 ` Alejandro Colomar (man-pages)
2021-07-03 20:09 ` Dan Robertson
2021-07-03 21:31 ` Alejandro Colomar (man-pages)
2021-07-03 22:55 ` Dan Robertson
2021-07-04 11:27 ` Alejandro Colomar (man-pages)
2021-07-03 18:18 ` [PATCH 0/1] man2/fallocate.2: Fix " Alejandro Colomar (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621042550.GG158232@locust \
--to=djwong@kernel.org \
--cc=alx.manpages@gmail.com \
--cc=dan@dlrobertson.com \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).