linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: will@williammanley.net, linux-man@vger.kernel.org,
	Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [PATCH] preadv2: Note preadv2(..., RWF_NOWAIT) bug in BUGS section
Date: Mon, 28 Jun 2021 22:19:42 +0200	[thread overview]
Message-ID: <c06bfb13-3e4e-633d-b54f-6b4a46173cc0@gmail.com> (raw)
In-Reply-To: <3f280647-143d-4c52-822a-79338a1b76f7@www.fastmail.com>

Hi Will,

On 6/1/21 4:15 PM, Will Manley wrote:
> To save the next person before they fall foul of it.  See
> https://lore.kernel.org/linux-fsdevel/fea8b16d-5a69-40f9-b123-e84dcd6e8f2e@www.fastmail.com/T/#u
> and https://github.com/tokio-rs/tokio/issues/3803 for more information.

Thanks. Patch applied.
Sorry for the delay!

I applied a few minor tweaks to your patch. See
<https://github.com/alejandro-colomar/man-pages/commits/main>.
I also added a signed-off-by line on your behalf.

Thanks,

Alex

> ---
>   man2/readv.2 | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/man2/readv.2 b/man2/readv.2
> index df42cf830..3355fa9d7 100644
> --- a/man2/readv.2
> +++ b/man2/readv.2
> @@ -243,7 +243,9 @@ If some data was successfully read, it will return the number of bytes read.
>   If no bytes were read, it will return \-1 and set
>   .IR errno
>   to
> -.BR EAGAIN .
> +.BR EAGAIN
> +(but see
> +.BR BUGS ")."
>   Currently, this flag is meaningful only for
>   .BR preadv2 ().
>   .TP
> @@ -425,6 +427,13 @@ iov[1].iov_len = strlen(str1);
>   nwritten = writev(STDOUT_FILENO, iov, 2);
>   .EE
>   .in
> +.SH BUGS
> +Linux v5.9 and v5.10 have a bug where
> +.BR preadv2()
> +with the
> +.BR RWF_NOWAIT
> +flag may return 0 even when not at end of file.  See
> +https://lore.kernel.org/linux-fsdevel/fea8b16d-5a69-40f9-b123-e84dcd6e8f2e@www.fastmail.com/T/#u
>   .SH SEE ALSO
>   .BR pread (2),
>   .BR read (2),
> 


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

      reply	other threads:[~2021-06-28 20:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 14:15 [PATCH] preadv2: Note preadv2(..., RWF_NOWAIT) bug in BUGS section Will Manley
2021-06-28 20:19 ` Alejandro Colomar (man-pages) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c06bfb13-3e4e-633d-b54f-6b4a46173cc0@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=will@williammanley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).