From: Marek Vasut <marex@denx.de>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings
Date: Tue, 6 Aug 2019 15:35:54 +0200 [thread overview]
Message-ID: <02ec97ea-fd7d-cb89-c413-2c1bc847bd9c@denx.de> (raw)
In-Reply-To: <20190701080457.acucsi6p3mlmbg75@paasikivi.fi.intel.com>
On 7/1/19 10:04 AM, Sakari Ailus wrote:
> Hi Marek,
>
> On Mon, May 20, 2019 at 10:18:11PM +0200, Marek Vasut wrote:
>> Add bindings for the Intersil ISL7998x BT656-to-MIPI-CSI2 decoder.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
>> Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> To: linux-media@vger.kernel.org
>> ---
>> .../bindings/media/i2c/isl7998x.txt | 37 +++++++++++++++++++
>> 1 file changed, 37 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/media/i2c/isl7998x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/isl7998x.txt b/Documentation/devicetree/bindings/media/i2c/isl7998x.txt
>> new file mode 100644
>> index 000000000000..c21703983360
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/i2c/isl7998x.txt
>> @@ -0,0 +1,37 @@
>> +Intersil ISL7998x BT656-to-MIPI-CSI2 decoder
>> +
>> +The Intersil ISL7998x is a BT656-to-MIPI-CSI decoder which, capable of
>> +receiving up to four analog stream and multiplexing them into up to four
>> +MIPI CSI2 virtual channels, using one MIPI clock lane and 1/2 data lanes.
>> +
>> +Required Properties:
>> +- compatible: value should be "isil,isl79987"
>> +- pd-gpios: a GPIO spec for the Power Down pin (active high)
>> +
>> +Option Properties:
>> +- isil,num-inputs: Number of connected inputs (1, 2 or 4)
>
> The presence of ports describing connected Bt.656 inputs tells this.
>
>> +
>> +For further reading on port node refer to
>> +Documentation/devicetree/bindings/media/video-interfaces.txt.
>
> Which endpoint properties are relevant for the endpoint(s) in the CSI-2 port?
clock-lanes, data-lanes and the remote-endpoint .
> How about the ports describing the Bt.656 interfaces? You should have
> those, too...
So who would be connected to these analog "input" endpoint ? What would
be their "remote-endpoint" ?
>> +
>> +Example:
>> +
>> + i2c_master {
>> + isl7998x_mipi@44 {
>> + compatible = "isil,isl79987";
>> + reg = <0x44>;
>> + isil,num-inputs = <4>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_videoadc>;
>> + pd-gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>;
>> + status = "okay";
>> +
>> + port {
>> + isl79987_to_mipi_csi2: endpoint {
>> + remote-endpoint = <&mipi_csi2_in>;
>> + clock-lanes = <0>;
>> + data-lanes = <1 2>;
>> + };
>> + };
>> + };
>> + };
>>
>
--
Best regards,
Marek Vasut
prev parent reply other threads:[~2019-08-06 14:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 20:18 [PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings Marek Vasut
2019-05-20 20:18 ` [PATCH 2/2] media: i2c: isl7998x: Add driver for Intersil ISL7998x Marek Vasut
2019-07-01 7:58 ` Jacopo Mondi
2019-08-06 14:03 ` Marek Vasut
2019-08-12 15:39 ` Jacopo Mondi
2019-07-01 8:43 ` Sakari Ailus
2019-08-06 14:25 ` Marek Vasut
2019-07-01 8:46 ` Sakari Ailus
2019-05-28 11:47 ` [PATCH 1/2] media: dt-bindings: Add Intersil ISL7998x DT bindings Jacopo Mondi
2019-05-28 14:36 ` Marek Vasut
2019-05-28 15:10 ` Jacopo Mondi
2019-05-28 17:49 ` Marek Vasut
2019-05-29 6:28 ` Jacopo Mondi
2019-05-29 10:41 ` Marek Vasut
2019-05-29 11:04 ` Ian Arkver
2019-05-29 11:09 ` Marek Vasut
2019-05-29 11:15 ` Ian Arkver
2019-08-06 13:35 ` Marek Vasut
2019-05-29 13:43 ` Jacopo Mondi
2019-08-06 13:35 ` Marek Vasut
2019-07-01 8:04 ` Sakari Ailus
2019-08-06 13:35 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ec97ea-fd7d-cb89-c413-2c1bc847bd9c@denx.de \
--to=marex@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).