From: Philipp Zabel <p.zabel@pengutronix.de>
To: Nicolas Dufresne <nicolas@ndufresne.ca>,
Michael Tretter <m.tretter@pengutronix.de>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org
Cc: mchehab@kernel.org, robh+dt@kernel.org, kernel@pengutronix.de,
tfiga@chromium.org
Subject: Re: [PATCH v2 1/3] media: dt-bindings: media: document allegro-dvt bindings
Date: Mon, 21 Jan 2019 17:30:07 +0100 [thread overview]
Message-ID: <1548088207.3287.11.camel@pengutronix.de> (raw)
In-Reply-To: <26befa99cb1ddb0c36823cb573f2012d4bd98015.camel@ndufresne.ca>
On Mon, 2019-01-21 at 11:17 -0500, Nicolas Dufresne wrote:
[...]
> > > +Example:
> > > + al5e: al5e@a0009000 {
> >
> > Should the node names be "vpu" or "video-codec"?
>
> Xilinx calls this IP the "vcu", so "vpu" would be even more confusing.
> Was this just a typo ?
I was just going by what is already commonly used in other device trees.
Given that "vpu" doesn't seem to be as universally accepted as for
example "gpu", maybe "video-codec" is the better choice?
In any case, it should not matter what the the IP vendor or the SoC
vendor call this, the node name should be common and descriptive of its
function, same as ethernet controller nodes should be called "ethernet".
> That being said, is this referring to the actual
> HW or the firmware that runs on a microblaze (the firmware being
> Allegro specific) ?
As I understand it this binding is referring to the whole [microblaze +
attached encoder/decoder hardware] setup that is supposed to work with
the Allegro specific firmware.
regards
Philipp
next prev parent reply other threads:[~2019-01-21 16:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 13:37 [PATCH v2 0/3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver Michael Tretter
2019-01-18 13:37 ` [PATCH v2 1/3] media: dt-bindings: media: document allegro-dvt bindings Michael Tretter
2019-01-21 10:59 ` Philipp Zabel
2019-01-21 16:17 ` Nicolas Dufresne
2019-01-21 16:30 ` Philipp Zabel [this message]
2019-01-21 17:42 ` Michael Tretter
2019-01-21 17:13 ` Rob Herring
2019-01-22 13:38 ` Michael Tretter
2019-01-18 13:37 ` [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver Michael Tretter
2019-01-23 10:44 ` Hans Verkuil
2019-01-23 14:17 ` Michael Tretter
2019-01-30 3:46 ` Nicolas Dufresne
2019-01-30 3:54 ` Tomasz Figa
2019-01-30 9:22 ` Michael Tretter
2019-01-30 3:41 ` Nicolas Dufresne
2019-01-30 7:47 ` Hans Verkuil
2019-01-30 15:19 ` Nicolas Dufresne
2019-01-30 16:14 ` Michael Tretter
2019-01-18 13:37 ` [PATCH v2 3/3] [media] allegro: add SPS/PPS nal unit writer Michael Tretter
2019-01-18 14:11 ` [PATCH v2 0/3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver Hans Verkuil
2019-01-21 10:42 ` Michael Tretter
2019-01-23 10:48 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548088207.3287.11.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=robh+dt@kernel.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).