From: Mirela Rabulea <mirela.rabulea@nxp.com>
To: "paul.kocialkowski@bootlin.com" <paul.kocialkowski@bootlin.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"s.nawrocki@samsung.com" <s.nawrocki@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"vivek.kasireddy@intel.com" <vivek.kasireddy@intel.com>,
"boris.brezillon@collabora.com" <boris.brezillon@collabora.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Robert Chiras <robert.chiras@nxp.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"niklas.soderlund+renesas@ragnatech.se"
<niklas.soderlund+renesas@ragnatech.se>,
"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"ezequiel@collabora.com" <ezequiel@collabora.com>
Subject: Re: [EXT] Re: Re: [PATCH] media: v4l: Add packed YUV444 24bpp pixel format
Date: Fri, 12 Jul 2019 13:02:24 +0000 [thread overview]
Message-ID: <1562936544.9511.25.camel@nxp.com> (raw)
In-Reply-To: <20190712092121.GF15882@aptenodytes>
On Vi, 2019-07-12 at 11:21 +0200, paul.kocialkowski@bootlin.com wrote:
> Hi,
>
> On Thu 11 Jul 19, 13:57, Mirela Rabulea wrote:
> >
> > On Jo, 2019-07-11 at 10:18 +0200, Paul Kocialkowski wrote:
> > >
> > > Caution: EXT Email
> > >
> > > Hi,
> > >
> > > On Wed 03 Jul 19, 18:15, Mirela Rabulea wrote:
> > > >
> > > >
> > > > The added format is V4L2_PIX_FMT_YUV24, this is a packed
> > > > YUV 4:4:4 format, with 8 bits for each component, 24 bits
> > > > per sample.
> > > >
> > > > This format is used by the i.MX 8QuadMax and i.MX
> > > > 8DualXPlus/8QuadXPlus
> > > > JPEG encoder/decoder.
> > > So this format is not aligned to 32-bit words at all and we can
> > > expect
> > > to see cases where a single 32-bit word contains data for two
> > > pixels?
> > >
> > > Nothing wrong with that, just checking whether I understood this
> > > right :)
> > >
> > Hi Paul,
> > yes, your understanding is correct.
> Out of curiosity, is the JPEG block assmiliated to (one of) the
> Hantro VPUs
> or is it a totally different and unrelated hardware block?
>
> Anyway the change looks good to me:
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
>
> Cheers,
>
> Paul
Hi Paul,
thanks for taking the time to review.
The JPEG decoder is a standalone core & wrapper, not assimilated to the
VPU. It is described in the reference manual here:
https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdf
in chapters "15.6.3 JPEG Decoder (JPEGDEC)" and "15.6.5 JPEG Decoder
Wrapper".
The JPEG core is from a third party, and the wrapper from NXP.
Regards,
Mirela
next prev parent reply other threads:[~2019-07-12 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 15:15 [PATCH] media: v4l: Add packed YUV444 24bpp pixel format Mirela Rabulea
2019-07-03 15:15 ` Mirela Rabulea
2019-07-11 8:18 ` Paul Kocialkowski
2019-07-11 13:57 ` Mirela Rabulea
2019-07-12 9:21 ` paul.kocialkowski
2019-07-12 13:02 ` Mirela Rabulea [this message]
2019-08-13 6:54 ` Hans Verkuil
2019-08-22 15:00 ` Mirela Rabulea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562936544.9511.25.camel@nxp.com \
--to=mirela.rabulea@nxp.com \
--cc=boris.brezillon@collabora.com \
--cc=ezequiel@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=paul.kocialkowski@bootlin.com \
--cc=robert.chiras@nxp.com \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@linux.intel.com \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).