From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, "David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Rob Clark" <rob.clark@linaro.org>,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH 19/40] drm/omapdrm/omap_gem: Properly document omap_gem_dumb_map_offset()
Date: Fri, 23 Apr 2021 15:12:55 +0300 [thread overview]
Message-ID: <1597afec-291f-4b08-cfb5-f7b04f28f4bd@ideasonboard.com> (raw)
In-Reply-To: <20210416143725.2769053-20-lee.jones@linaro.org>
On 16/04/2021 17:37, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/omapdrm/omap_gem.c:619: warning: expecting prototype for omap_gem_dumb_map(). Prototype was for omap_gem_dumb_map_offset() instead
>
> Cc: Tomi Valkeinen <tomba@kernel.org>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Rob Clark <rob.clark@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/gpu/drm/omapdrm/omap_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index 38af6195d9593..27c71cded5d0a 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -605,7 +605,7 @@ int omap_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
> }
>
> /**
> - * omap_gem_dumb_map - buffer mapping for dumb interface
> + * omap_gem_dumb_map_offset - buffer mapping for dumb interface
> * @file: our drm client file
> * @dev: drm device
> * @handle: GEM handle to the object (from dumb_create)
>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
next prev parent reply other threads:[~2021-04-23 12:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 14:36 [PATCH 00/40] [Set 16] Rid W=1 warnings from GPU! Lee Jones
2021-04-16 14:36 ` [PATCH 07/40] drm/nouveau/nouveau_bo: Remove unused variables 'dev' Lee Jones
2021-04-19 11:44 ` [Nouveau] " Karol Herbst
2021-04-16 14:37 ` [PATCH 19/40] drm/omapdrm/omap_gem: Properly document omap_gem_dumb_map_offset() Lee Jones
2021-04-23 12:12 ` Tomi Valkeinen [this message]
2021-04-16 14:37 ` [PATCH 23/40] drm/ttm/ttm_bo: Fix incorrectly documented function 'ttm_bo_cleanup_refs' Lee Jones
2021-04-16 15:31 ` Christian König
2021-04-20 21:27 ` Alex Deucher
2021-04-21 7:02 ` Christian König
2021-04-16 14:37 ` [PATCH 24/40] drm/scheduler/sched_entity: Fix some function name disparity Lee Jones
2021-04-16 14:37 ` [PATCH 26/40] drm/amd/amdgpu/amdgpu_device: Remove unused variable 'r' Lee Jones
2021-04-20 23:53 ` Alex Deucher
2021-04-16 14:37 ` [PATCH 29/40] drm/amd/amdgpu/amdgpu_fence: Provide description for 'sched_score' Lee Jones
2021-04-16 15:52 ` Christian König
2021-04-20 23:57 ` Alex Deucher
2021-04-16 14:37 ` [PATCH 30/40] drm/vgem/vgem_drv: Demote kernel-doc abuse Lee Jones
2021-04-16 14:37 ` [PATCH 32/40] drm/amd/amdgpu/amdgpu_ttm: Fix incorrectly documented function 'amdgpu_ttm_copy_mem_to_mem()' Lee Jones
2021-04-16 15:53 ` Christian König
2021-04-21 0:00 ` Alex Deucher
2021-04-16 14:37 ` [PATCH 33/40] drm/amd/amdgpu/amdgpu_ring: Provide description for 'sched_score' Lee Jones
2021-04-16 15:54 ` Christian König
2021-04-21 0:01 ` Alex Deucher
2021-04-16 14:37 ` [PATCH 35/40] drm/amd/amdgpu/amdgpu_cs: Repair some function naming disparity Lee Jones
2021-04-16 15:54 ` Christian König
2021-04-21 0:03 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597afec-291f-4b08-cfb5-f7b04f28f4bd@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee.jones@linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rob.clark@linaro.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).