From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAD35C35245 for ; Sat, 25 Jan 2020 11:20:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 876B42075E for ; Sat, 25 Jan 2020 11:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbgAYLUW (ORCPT ); Sat, 25 Jan 2020 06:20:22 -0500 Received: from mailoutvs4.siol.net ([185.57.226.195]:34697 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725767AbgAYLUW (ORCPT ); Sat, 25 Jan 2020 06:20:22 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 7DE3B520C74; Sat, 25 Jan 2020 12:20:19 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ydjZDDwb9wfv; Sat, 25 Jan 2020 12:20:19 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 2BF84520C7E; Sat, 25 Jan 2020 12:20:19 +0100 (CET) Received: from jernej-laptop.localnet (cpe-194-152-20-232.static.triera.net [194.152.20.232]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id AF879520C74; Sat, 25 Jan 2020 12:20:18 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai Cc: Maxime Ripard , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Mike Turquette , Stephen Boyd , Hans Verkuil , Linux Media Mailing List , devicetree , linux-arm-kernel , linux-kernel , linux-clk , linux-sunxi Subject: Re: [linux-sunxi] [PATCH 1/8] clk: sunxi-ng: sun8i-de2: Swap A64 and H6 definitions Date: Sat, 25 Jan 2020 12:20:18 +0100 Message-ID: <2008374.irdbgypaU6@jernej-laptop> In-Reply-To: References: <20200124232014.574989-1-jernej.skrabec@siol.net> <20200124232014.574989-2-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi! Dne sobota, 25. januar 2020 ob 04:05:33 CET je Chen-Yu Tsai napisal(a): > On Sat, Jan 25, 2020 at 7:20 AM Jernej Skrabec wrote: > > For some reason, A64 and H6 have swapped clocks and resets definitions. > > H6 doesn't have rotation unit while A64 has. Swap around to correct the > > issue. > > > > Signed-off-by: Jernej Skrabec > > Could you add Fixes tags for this one? I'm not sure which commit to reference. H6 one? or also initial A64 one? I just found out that H5 compatible uses A64 structure, which is not correct. H5 doesn't contain rotate core. Do you have any better idea how to nicely solve this mess? I'm thinking that for v2 I would first decouple some compatibles, like this for H5 and R40 and V3s from A83T (as it can be seen in the next patch). After that, rather than switching definitions I would fix each compatible one by one. At the end, if any entry is duplicated, I can add one commit to merge same structures. What do you think? Best regards, Jernej