linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Longerbeam <slongerbeam@gmail.com>
To: linux-media@vger.kernel.org
Cc: Steve Longerbeam <slongerbeam@gmail.com>
Subject: [PATCH v5 00/12] imx-media: Fixes for interlaced capture
Date: Tue, 16 Oct 2018 17:00:15 -0700	[thread overview]
Message-ID: <20181017000027.23696-1-slongerbeam@gmail.com> (raw)

A set of patches that fixes some bugs with capturing from an
interlaced source, and incompatibilites between IDMAC interlace
interweaving and 4:2:0 data write reduction.

History:
v5:
- Added a regression fix to allow empty endpoints to CSI (fix for imx6q
  SabreAuto).
- Cleaned up some convoluted code in ipu_csi_init_interface(), suggested
  by Philipp Zabel.
- Fixed a regression in csi_setup(), caught by Philipp.
- Removed interweave_offset and replace with boolean interweave_swap,
  suggested by Philipp.
- Make clear that it is IDMAC channel that does pixel reordering and
  interweave, not the CSI, in the imx.rst doc, caught by Philipp.

v4:
- rebased to latest media-tree master branch.
- Make patch author and SoB email addresses the same.

v3:
- add support for/fix interweaved scan with YUV planar output.
- fix bug in 4:2:0 U/V offset macros.
- add patch that generalizes behavior of field swap in
  ipu_csi_init_interface().
- add support for interweaved scan with field order swap.
  Suggested by Philipp Zabel.
- in v2, inteweave scan was determined using field types of
  CSI (and PRPENCVF) at the sink and source pads. In v3, this
  has been moved one hop downstream: interweave is now determined
  using field type at source pad, and field type selected at
  capture interface. Suggested by Philipp.
- make sure to double CSI crop target height when input field
  type in alternate.
- more updates to media driver doc to reflect above.

v2:
- update media driver doc.
- enable idmac interweave only if input field is sequential/alternate,
  and output field is 'interlaced*'.
- move field try logic out of *try_fmt and into separate function.
- fix bug with resetting crop/compose rectangles.
- add a patch that fixes a field order bug in VDIC indirect mode.
- remove alternate field type from V4L2_FIELD_IS_SEQUENTIAL() macro
  Suggested-by: Nicolas Dufresne <nicolas@ndufresne.ca>.
- add macro V4L2_FIELD_IS_INTERLACED().


Steve Longerbeam (12):
  media: videodev2.h: Add more field helper macros
  gpu: ipu-csi: Swap fields according to input/output field types
  gpu: ipu-v3: Add planar support to interlaced scan
  media: imx: Fix field negotiation
  media: imx-csi: Input connections to CSI should be optional
  media: imx-csi: Double crop height for alternate fields at sink
  media: imx: interweave and odd-chroma-row skip are incompatible
  media: imx-csi: Allow skipping odd chroma rows for YVU420
  media: imx: vdic: rely on VDIC for correct field order
  media: imx-csi: Move crop/compose reset after filling default mbus
    fields
  media: imx: Allow interweave with top/bottom lines swapped
  media: imx.rst: Update doc to reflect fixes to interlaced capture

 Documentation/media/v4l-drivers/imx.rst       | 103 +++++++----
 drivers/gpu/ipu-v3/ipu-cpmem.c                |  26 ++-
 drivers/gpu/ipu-v3/ipu-csi.c                  | 119 +++++++++----
 drivers/staging/media/imx/imx-ic-prpencvf.c   |  46 +++--
 drivers/staging/media/imx/imx-media-capture.c |  14 ++
 drivers/staging/media/imx/imx-media-csi.c     | 168 +++++++++++++-----
 drivers/staging/media/imx/imx-media-vdic.c    |  12 +-
 include/uapi/linux/videodev2.h                |   7 +
 include/video/imx-ipu-v3.h                    |   6 +-
 9 files changed, 354 insertions(+), 147 deletions(-)

-- 
2.17.1

             reply	other threads:[~2018-10-17  7:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17  0:00 Steve Longerbeam [this message]
2018-10-17  0:00 ` [PATCH v5 01/12] media: videodev2.h: Add more field helper macros Steve Longerbeam
2018-10-17  0:00 ` [PATCH v5 02/12] gpu: ipu-csi: Swap fields according to input/output field types Steve Longerbeam
2018-12-07 20:02   ` Steve Longerbeam
2018-12-13 12:59   ` Philipp Zabel
2018-12-14 23:40     ` Steve Longerbeam
2018-10-17  0:00 ` [PATCH v5 03/12] gpu: ipu-v3: Add planar support to interlaced scan Steve Longerbeam
2018-10-17  0:00 ` [PATCH v5 04/12] media: imx: Fix field negotiation Steve Longerbeam
2018-10-17  0:00 ` [PATCH v5 05/12] media: imx-csi: Input connections to CSI should be optional Steve Longerbeam
2018-10-17  0:00 ` [PATCH v5 06/12] media: imx-csi: Double crop height for alternate fields at sink Steve Longerbeam
2018-10-17  0:00 ` [PATCH v5 07/12] media: imx: interweave and odd-chroma-row skip are incompatible Steve Longerbeam
2018-10-17  0:00 ` [PATCH v5 08/12] media: imx-csi: Allow skipping odd chroma rows for YVU420 Steve Longerbeam
2018-10-17  0:00 ` [PATCH v5 09/12] media: imx: vdic: rely on VDIC for correct field order Steve Longerbeam
2018-10-17  0:00 ` [PATCH v5 10/12] media: imx-csi: Move crop/compose reset after filling default mbus fields Steve Longerbeam
2018-10-17  0:00 ` [PATCH v5 11/12] media: imx: Allow interweave with top/bottom lines swapped Steve Longerbeam
2018-10-17  0:00 ` [PATCH v5 12/12] media: imx.rst: Update doc to reflect fixes to interlaced capture Steve Longerbeam
2018-12-07 13:35 ` [PATCH v5 00/12] imx-media: Fixes for " Hans Verkuil
2018-12-07 20:07   ` Steve Longerbeam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181017000027.23696-1-slongerbeam@gmail.com \
    --to=slongerbeam@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).