From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: bingbu.cao@intel.com
Cc: linux-media@vger.kernel.org, tfiga@chromium.org,
rajmohan.mani@intel.com, bingbu.cao@linux.intel.com,
mchehab+samsung@kernel.org, hverkuil@xs4all.nl
Subject: Re: [PATCH 2/2] media: imx355: fix wrong order in test pattern menus
Date: Mon, 26 Nov 2018 10:57:32 +0200 [thread overview]
Message-ID: <20181126085732.vupidoa2lozp5ndo@paasikivi.fi.intel.com> (raw)
In-Reply-To: <1543218214-10767-2-git-send-email-bingbu.cao@intel.com>
Hi Bing Bu,
On Mon, Nov 26, 2018 at 03:43:34PM +0800, bingbu.cao@intel.com wrote:
> From: Bingbu Cao <bingbu.cao@intel.com>
>
> current imx355 test pattern order in ctrl menu
> is not correct, this patch fixes it.
>
> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> ---
> drivers/media/i2c/imx355.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index 20c8eea5db4b..9c9559dfd3dd 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
> @@ -876,8 +876,8 @@ struct imx355 {
>
> static const char * const imx355_test_pattern_menu[] = {
> "Disabled",
> - "100% color bars",
> "Solid color",
> + "100% color bars",
> "Fade to gray color bars",
> "PN9"
> };
While at it, could you use the existing test pattern naming as well for the
drivers? That could be a separate patch.
>From drivers/media/i2c/smiapp/smiapp-core.c :
static const char * const smiapp_test_patterns[] = {
"Disabled",
"Solid Colour",
"Eight Vertical Colour Bars",
"Colour Bars With Fade to Grey",
"Pseudorandom Sequence (PN9)",
};
It's not strictly necessary from interface point of view, but for the user
space it'd be good to align the naming.
--
Regards,
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2018-11-26 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 7:43 [PATCH 1/2] media: imx319: fix wrong order in test pattern menus bingbu.cao
2018-11-26 7:43 ` [PATCH 2/2] media: imx355: " bingbu.cao
2018-11-26 8:57 ` Sakari Ailus [this message]
2018-11-26 9:43 ` Bingbu Cao
2018-11-27 2:45 ` Bingbu Cao
2018-11-27 9:22 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126085732.vupidoa2lozp5ndo@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).