From: Matthew Wilcox <willy@infradead.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
akpm@linux-foundation.org, mhocko@suse.com,
kirill.shutemov@linux.intel.com, vbabka@suse.cz,
riel@surriel.com, sfr@canb.auug.org.au, rppt@linux.vnet.ibm.com,
peterz@infradead.org, linux@armlinux.org.uk,
iamjoonsoo.kim@lge.com, treding@nvidia.com,
keescook@chromium.org, m.szyprowski@samsung.com,
stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, heiko@sntech.de,
airlied@linux.ie, oleksandr_andrushchenko@epam.com,
joro@8bytes.org, pawel@osciak.com, kyungmin.park@samsung.com,
mchehab@kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org,
linux1394-devel@lists.sourceforge.net,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, xen-devel@lists.xen.org,
iommu@lists.linux-foundation.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v3 1/9] mm: Introduce new vm_insert_range API
Date: Fri, 7 Dec 2018 09:11:16 -0800 [thread overview]
Message-ID: <20181207171116.GA29923@bombadil.infradead.org> (raw)
In-Reply-To: <53bbc095-c9f5-5d6a-6e50-6e060d17eb68@arm.com>
On Fri, Dec 07, 2018 at 03:34:56PM +0000, Robin Murphy wrote:
> > +int vm_insert_range(struct vm_area_struct *vma, unsigned long addr,
> > + struct page **pages, unsigned long page_count)
> > +{
> > + unsigned long uaddr = addr;
> > + int ret = 0, i;
>
> Some of the sites being replaced were effectively ensuring that vma and
> pages were mutually compatible as an initial condition - would it be worth
> adding something here for robustness, e.g.:
>
> + if (page_count != vma_pages(vma))
> + return -ENXIO;
I think we want to allow this to be used to populate part of a VMA.
So perhaps:
if (page_count > vma_pages(vma))
return -ENXIO;
next prev parent reply other threads:[~2018-12-07 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 18:39 [PATCH v3 1/9] mm: Introduce new vm_insert_range API Souptick Joarder
2018-12-07 14:47 ` Mauro Carvalho Chehab
2018-12-07 15:34 ` Robin Murphy
2018-12-07 17:11 ` Matthew Wilcox [this message]
2018-12-07 19:28 ` Souptick Joarder
2018-12-07 21:10 ` Robin Murphy
2018-12-07 21:48 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207171116.GA29923@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=jrdr.linux@gmail.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=mhocko@suse.com \
--cc=oleksandr_andrushchenko@epam.com \
--cc=pawel@osciak.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=stefanr@s5r6.in-berlin.de \
--cc=treding@nvidia.com \
--cc=vbabka@suse.cz \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).