From: Adam Stylinski <kungfujesus06@gmail.com>
To: "French, Nicholas A." <naf@ou.edu>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] media: lgdt330x: fix lock status reporting
Date: Mon, 10 Dec 2018 12:50:44 -0500 [thread overview]
Message-ID: <20181210175044.GA30987@eggsbenedict.adamsnet> (raw)
In-Reply-To: <20181209071054.GA14422@tivo>
[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]
On Sun, Dec 09, 2018 at 07:11:18AM +0000, French, Nicholas A. wrote:
> A typo in code cleanup commit db9c1007bc07 ("media: lgdt330x: do
> some cleanups at status logic") broke the FE_HAS_LOCK reporting
> for 3303 chips by inadvertently modifying the register mask.
>
> The broken lock status is critial as it prevents video capture
> cards from reporting signal strength, scanning for channels,
> and capturing video.
>
> Fix regression by reverting mask change.
>
> Signed-off-by: Nick French <naf@ou.edu>
> ---
> drivers/media/dvb-frontends/lgdt330x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/lgdt330x.c b/drivers/media/dvb-frontends/lgdt330x.c
> index 96807e134886..8abb1a510a81 100644
> --- a/drivers/media/dvb-frontends/lgdt330x.c
> +++ b/drivers/media/dvb-frontends/lgdt330x.c
> @@ -783,7 +783,7 @@ static int lgdt3303_read_status(struct dvb_frontend *fe,
>
> if ((buf[0] & 0x02) == 0x00)
> *status |= FE_HAS_SYNC;
> - if ((buf[0] & 0xfd) == 0x01)
> + if ((buf[0] & 0x01) == 0x01)
> *status |= FE_HAS_VITERBI | FE_HAS_LOCK;
> break;
> default:
> --
> 2.19.2
>
Patch worked for me.
Tested-by: Adam Stylinski <kungfujesus06@gmail.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-12-10 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 7:11 [PATCH] media: lgdt330x: fix lock status reporting French, Nicholas A.
2018-12-09 12:30 ` Laurent Pinchart
2018-12-10 17:50 ` Adam Stylinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210175044.GA30987@eggsbenedict.adamsnet \
--to=kungfujesus06@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=naf@ou.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).