linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Dafna Hirschfeld <dafna3@gmail.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH 0/3] vb2: add requires_requests bitfield
Date: Mon, 11 Feb 2019 10:18:13 +0100	[thread overview]
Message-ID: <20190211091816.33022-1-hverkuil-cisco@xs4all.nl> (raw)

Currently the supports_requests bitfield only indicates if the
Request API is supported by the vb2_queue. But for stateless
codecs the use of the Request API is actually a requirement.

So add a requires_requests bitfield and corresponding capability
to indicate that userspace has to use requests. And of course
reject direct VIDIOC_QBUF calls (i.e. V4L2_BUF_FLAG_REQUEST_FD
isn't set) if requires_requests is set.

Finally set this bitfield in the cedrus driver.

Regards,

	Hans

Hans Verkuil (3):
  vb2: add requires_requests bit for stateless codecs
  videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS
  cedrus: set requires_requests

 Documentation/media/uapi/v4l/vidioc-reqbufs.rst   | 4 ++++
 drivers/media/common/videobuf2/videobuf2-core.c   | 5 ++++-
 drivers/media/common/videobuf2/videobuf2-v4l2.c   | 6 ++++++
 drivers/staging/media/sunxi/cedrus/cedrus_video.c | 1 +
 include/media/videobuf2-core.h                    | 3 +++
 include/uapi/linux/videodev2.h                    | 1 +
 6 files changed, 19 insertions(+), 1 deletion(-)

-- 
2.20.1


             reply	other threads:[~2019-02-11  9:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11  9:18 Hans Verkuil [this message]
2019-02-11  9:18 ` [PATCH 1/3] vb2: add requires_requests bit for stateless codecs Hans Verkuil
2019-02-11  9:18 ` [PATCH 2/3] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS Hans Verkuil
2019-02-11  9:18 ` [PATCH 3/3] cedrus: set requires_requests Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211091816.33022-1-hverkuil-cisco@xs4all.nl \
    --to=hverkuil-cisco@xs4all.nl \
    --cc=dafna3@gmail.com \
    --cc=ezequiel@collabora.com \
    --cc=linux-media@vger.kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).