From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Ian Arkver <ian.arkver.dev@gmail.com>,
hans.verkuil@cisco.com, mchehab@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, graphics@pengutronix.de
Subject: Re: [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746
Date: Mon, 4 Mar 2019 20:17:48 +0200 [thread overview]
Message-ID: <20190304181747.ax7nvbvhdul4vtna@kekkonen.localdomain> (raw)
In-Reply-To: <20190304165528.n4sqxjhfsplmt5km@pengutronix.de>
Hi Marco,
On Mon, Mar 04, 2019 at 05:55:28PM +0100, Marco Felsch wrote:
> > > (more device specific)
> > > tc358746,default-mode = <CSI-Tx> /* Parallel-in -> CSI-out */
> > > tc358746,default-mode = <CSI-Rx> /* CSI-in -> Parallel-out */
> > >
> > > or
> > >
> > > (more generic)
> > > tc358746,default-dir = <PARALLEL_TO_CSI2>
> > > tc358746,default-dir = <CSI2_TO_PARALLEL>
> >
> > The prefix for Toshiba is "toshiba". What would you think of
> > "toshiba,csi2-direction" with values of either "rx" or "tx"? Or
> > "toshiba,csi2-mode" with either "master" or "slave", which would be a
> > little bit more generic, but could be slightly more probable to get wrong
> > as well.
>
> You're right mixed the prefix with the device.. If we need to introduce
> a property I would prefer the "toshiba,csi2-direction" one. I said if
> because as Jacopo mentioned we can avoid the property by define port@0
> as input and port@1 as output. I tink that's the best solution, since we
> can avoid device specific bindings and it's common to use the last port
> as output (e.g. video-mux).
The ports represent hardware and I think I would avoid reordering them. I
wonder what would the DT folks prefer.
The device specific property is to the point at least: it describes an
orthogonal part of the device configuration. That's why I'd pick that if I
were to choose. But I'll let Rob to comment on this.
--
Regards,
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2019-03-04 18:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 14:12 [PATCH 0/3] media: add Toshiba TC358746 Bridge support Marco Felsch
2018-12-18 14:12 ` [PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746 Marco Felsch
2018-12-28 23:10 ` Rob Herring
2019-02-13 17:57 ` Jacopo Mondi
2019-03-01 10:26 ` Marco Felsch
2019-03-04 9:38 ` Jacopo Mondi
2019-03-04 16:43 ` Marco Felsch
2019-02-18 10:03 ` Sakari Ailus
2019-03-01 10:52 ` Marco Felsch
2019-03-01 11:07 ` Ian Arkver
2019-03-01 13:01 ` Marco Felsch
2019-03-04 9:41 ` Jacopo Mondi
2019-03-04 12:36 ` Sakari Ailus
2019-03-04 16:55 ` Marco Felsch
2019-03-04 18:17 ` Sakari Ailus [this message]
2019-03-05 8:49 ` Jacopo Mondi
2019-03-05 18:14 ` Marco Felsch
2019-04-16 10:45 ` Marco Felsch
2019-04-29 16:44 ` Marco Felsch
2019-03-04 12:10 ` Sakari Ailus
2018-12-18 14:12 ` [PATCH 2/3] media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver Marco Felsch
2018-12-19 1:24 ` kbuild test robot
2018-12-20 19:37 ` kbuild test robot
2019-02-18 11:25 ` Sakari Ailus
2018-12-18 14:12 ` [PATCH 3/3] media: tc358746: update MAINTAINERS file Marco Felsch
2019-02-18 11:46 ` Sakari Ailus
2019-03-04 17:31 ` Marco Felsch
2019-03-04 18:18 ` Sakari Ailus
2019-01-23 12:54 ` [PATCH 0/3] media: add Toshiba TC358746 Bridge support Marco Felsch
2019-02-12 16:10 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304181747.ax7nvbvhdul4vtna@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=graphics@pengutronix.de \
--cc=hans.verkuil@cisco.com \
--cc=ian.arkver.dev@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).