From: Jacopo Mondi <jacopo@jmondi.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com,
niklas.soderlund+renesas@ragnatech.se,
kieran.bingham@ideasonboard.com, linux-media@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
dave.stevenson@raspberrypi.org
Subject: Re: [RFC 1/5] v4l: subdev: Add MIPI CSI-2 PHY to frame desc
Date: Mon, 18 Mar 2019 09:23:53 +0100 [thread overview]
Message-ID: <20190318082353.b4khazdi4l77aobr@uno.localdomain> (raw)
In-Reply-To: <356313ee-2370-e5dc-4c19-2f2c900a410f@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 1939 bytes --]
Hello,
On Sat, Mar 16, 2019 at 07:20:28PM +0300, Sergei Shtylyov wrote:
> On 03/16/2019 06:47 PM, Jacopo Mondi wrote:
>
> > Add PHY-specific parameters to MIPI CSI-2 frame descriptor.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > ---
> > include/media/v4l2-subdev.h | 42 +++++++++++++++++++++++++++++++------
> > 1 file changed, 36 insertions(+), 6 deletions(-)
> >
> > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> > index 6311f670de3c..eca9633c83bf 100644
> > --- a/include/media/v4l2-subdev.h
> > +++ b/include/media/v4l2-subdev.h
> [...]
> > @@ -371,18 +393,26 @@ enum v4l2_mbus_frame_desc_type {
> > V4L2_MBUS_FRAME_DESC_TYPE_PLATFORM,
> > V4L2_MBUS_FRAME_DESC_TYPE_PARALLEL,
> > V4L2_MBUS_FRAME_DESC_TYPE_CCP2,
> > - V4L2_MBUS_FRAME_DESC_TYPE_CSI2,
> > + V4L2_MBUS_FRAME_DESC_TYPE_CSI2_DPHY,
> > + V4L2_MBUS_FRAME_DESC_TYPE_CSI2_CPHY,
> > };
> >
> > /**
> > * struct v4l2_mbus_frame_desc - media bus data frame description
> > - * @type: type of the bus (enum v4l2_mbus_frame_desc_type)
> > - * @entry: frame descriptors array
> > - * @num_entries: number of entries in @entry array
> > + * @type: type of the bus (enum v4l2_mbus_frame_desc_type)
> > + * @entry: frame descriptors array
> > + * @phy: PHY specific parameters
> > + * @phy.dphy: MIPI D-PHY specific bus configurations
> > + * @phy.cphy: MIPI C-PHY specific bus configurations
>
> The union members have csi2_ prefix in their names, no?
>
Correct! Thanks Sergei for noticing this!
> > + * @num_entries: number of entries in @entry array
> > */
> > struct v4l2_mbus_frame_desc {
> > enum v4l2_mbus_frame_desc_type type;
> > struct v4l2_mbus_frame_desc_entry entry[V4L2_FRAME_DESC_ENTRY_MAX];
> > + union {
> > + struct v4l2_mbus_frame_desc_entry_csi2_dphy csi2_dphy;
> > + struct v4l2_mbus_frame_desc_entry_csi2_cphy csi2_cphy;
> > + } phy;
> > unsigned short num_entries;
> > };
> >
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-03-18 8:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-16 15:47 [RFC 0/5] media: Implement negotiation of CSI-2 data lanes Jacopo Mondi
2019-03-16 15:47 ` [RFC 1/5] v4l: subdev: Add MIPI CSI-2 PHY to frame desc Jacopo Mondi
2019-03-16 16:20 ` Sergei Shtylyov
2019-03-18 8:23 ` Jacopo Mondi [this message]
2019-03-16 17:51 ` Sakari Ailus
2019-03-18 8:31 ` Jacopo Mondi
2019-03-18 15:29 ` Dave Stevenson
2019-03-20 16:45 ` Jacopo Mondi
2019-04-04 8:49 ` Sakari Ailus
2019-04-04 16:36 ` Dave Stevenson
2019-04-10 16:51 ` Jacopo Mondi
2019-03-16 15:47 ` [RFC 2/5] media: adv748x: Post-pone IO10 write to power up Jacopo Mondi
2019-04-12 14:15 ` Kieran Bingham
2019-04-12 14:45 ` Jacopo Mondi
2019-04-12 15:57 ` Kieran Bingham
2019-04-15 7:00 ` Jacopo Mondi
2020-06-10 9:50 ` Kieran Bingham
2019-03-16 15:47 ` [RFC 3/5] media: adv748x: Make lanes number depend on routing Jacopo Mondi
2019-04-12 14:45 ` Kieran Bingham
2019-03-16 15:48 ` [RFC 4/5] media: adv748x: Report D-PHY configuration Jacopo Mondi
2019-03-16 15:48 ` [RFC 5/5] media: rcar-csi2: Configure CSI-2 with frame desc Jacopo Mondi
2019-03-20 19:50 ` Niklas Söderlund
2019-03-21 0:51 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318082353.b4khazdi4l77aobr@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=dave.stevenson@raspberrypi.org \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).