From: Sean Young <sean@mess.org>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: Bastien Nocera <hadess@hadess.net>, linux-media@vger.kernel.org
Subject: Re: Keymap with duplicate entries
Date: Wed, 3 Jul 2019 10:23:15 +0100 [thread overview]
Message-ID: <20190703092315.ij3dwtuxgwvkvdfz@gofer.mess.org> (raw)
In-Reply-To: <2b07545f-94b6-7c12-e569-0e0a341b961a@gmail.com>
On Tue, Jul 02, 2019 at 11:29:58PM +0100, Malcolm Priestley wrote:
> > Hey Malcolm,
> >
> > There seems to be a problem in the keymap you provided for inclusion
> > in the kernel.
> >
> > In media/rc/keymaps/rc-it913x-v2.c, 2 keys are triggered by the same
> > keycode:
> > 53 ↦ { 0x866b18, KEY_VOLUMEDOWN },•
> > 55 ↦ { 0x866b18, KEY_CHANNELDOWN },•
> Hmm
>
> I don't have this remote only the first one in this file.
>
> I am pretty sure the values for the second type were forwarded to me by another user.
I'm pretty sure (although I have not tested this) that the second mapping
will overwite the first, so after the keymap is loaded 0x866b18 will be
mapped to KEY_CHANNELDOWN.
The current toml isn't loaded able but the kernel will set the initial
keymap.
So, do current kernels work correctly with the remote you have?
Thanks,
Sean
next prev parent reply other threads:[~2019-07-03 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 16:38 Keymap with duplicate entries Bastien Nocera
2019-07-02 22:29 ` Malcolm Priestley
2019-07-03 9:23 ` Sean Young [this message]
2019-07-03 20:41 ` Malcolm Priestley
-- strict thread matches above, loose matches on Subject: below --
2019-07-01 16:38 Bastien Nocera
2019-07-01 16:42 ` Bastien Nocera
2019-07-01 16:38 Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703092315.ij3dwtuxgwvkvdfz@gofer.mess.org \
--to=sean@mess.org \
--cc=hadess@hadess.net \
--cc=linux-media@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).