From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: mchehab@kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, c.barrett@framos.com,
linux-kernel@vger.kernel.org, a.brela@framos.com,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding
Date: Tue, 13 Aug 2019 17:21:47 +0530 [thread overview]
Message-ID: <20190813115147.GB28877@Mani-XPS-13-9360> (raw)
In-Reply-To: <20190813113846.GG13294@shell.armlinux.org.uk>
Hi Russel,
On Tue, Aug 13, 2019 at 12:38:46PM +0100, Russell King - ARM Linux admin wrote:
> On Tue, Aug 06, 2019 at 06:39:36PM +0530, Manivannan Sadhasivam wrote:
> > +Required Properties:
> > +- compatible: Should be "sony,imx290"
> > +- reg: I2C bus address of the device
> > +- clocks: Reference to the xclk clock.
> > +- clock-names: Should be "xclk".
> > +- clock-frequency: Frequency of the xclk clock.
>
> Driver code:
>
> + ret = of_property_read_u32(dev->of_node, "clock-frequency", &xclk_freq);+ if (ret) {
> + dev_err(dev, "Could not get xclk frequency\n");
> + return ret;
> + }
> +
> + /* external clock must be 37.125 MHz */
> + if (xclk_freq != 37125000) {
> + dev_err(dev, "External clock frequency %u is not supported\n",
> + xclk_freq);
> + return -EINVAL;
> + }
>
> So, only 37125000 is supported - is that not worth mentioning in this
> description? Is this a hard requirement of the sensor? If so, why
> does it need to be mentioned in the DT binding?
>
Actually, sensor supports only 2 clock frequencies: 37.125 MHz and 74.25 MHz.
And the driver currently supports only 37.125, because that's what I can test
with my setup.
So how about below:
clock-frequency: Frequency of the xclk clock in Hz. It should be one of the
following:
- 37125000
- 74250000
Thanks,
Mani
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-08-13 11:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 13:09 [PATCH v2 0/3] Add IMX290 CMOS image sensor support Manivannan Sadhasivam
2019-08-06 13:09 ` [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding Manivannan Sadhasivam
2019-08-13 9:45 ` Sakari Ailus
2019-08-13 11:33 ` Manivannan Sadhasivam
2019-08-13 11:46 ` Sakari Ailus
2019-08-13 12:14 ` Manivannan Sadhasivam
2019-08-13 12:22 ` Sakari Ailus
2019-08-13 13:52 ` Manivannan Sadhasivam
2019-08-13 14:18 ` Sakari Ailus
2019-08-13 11:38 ` Russell King - ARM Linux admin
2019-08-13 11:51 ` Manivannan Sadhasivam [this message]
2019-08-13 11:52 ` Sakari Ailus
2019-08-13 11:54 ` Sakari Ailus
2019-08-13 12:16 ` Manivannan Sadhasivam
2019-08-06 13:09 ` [PATCH v2 2/3] media: i2c: Add IMX290 CMOS image sensor driver Manivannan Sadhasivam
2019-08-13 10:59 ` Sakari Ailus
2019-08-29 17:04 ` Manivannan Sadhasivam
2019-08-29 20:17 ` Sakari Ailus
2019-08-06 13:09 ` [PATCH v2 3/3] MAINTAINERS: Add entry for " Manivannan Sadhasivam
2019-08-13 9:23 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813115147.GB28877@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=a.brela@framos.com \
--cc=c.barrett@framos.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).