From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: dongchun.zhu@mediatek.com
Cc: mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
drinkcat@chromium.org, tfiga@chromium.org,
matthias.bgg@gmail.com, bingbu.cao@intel.com,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, sj.huang@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
louis.kuo@mediatek.com, shengnan.wang@mediatek.com,
Ben Kao <ben.kao@intel.com>
Subject: Re: [V1, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856
Date: Tue, 13 Aug 2019 14:55:54 +0300 [thread overview]
Message-ID: <20190813115554.GA6133@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20190808165416.GA1845@kekkonen.localdomain>
On Thu, Aug 08, 2019 at 07:54:16PM +0300, Sakari Ailus wrote:
> Hi Dongchun,
>
> (Cc'ing Ben, too.)
>
> On Thu, Aug 08, 2019 at 05:22:14PM +0800, dongchun.zhu@mediatek.com wrote:
> > From: Dongchun Zhu <dongchun.zhu@mediatek.com>
> >
> > Add device tree binding documentation for the ov8856 camera sensor.
> >
> > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> > ---
> > .../devicetree/bindings/media/i2c/ov8856.txt | 41 ++++++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 42 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.txt
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.txt b/Documentation/devicetree/bindings/media/i2c/ov8856.txt
> > new file mode 100644
> > index 0000000..96b10e0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.txt
> > @@ -0,0 +1,41 @@
> > +* Omnivision OV8856 MIPI CSI-2 sensor
> > +
> > +Required Properties:
> > +- compatible: shall be "ovti,ov8856"
> > +- clocks: reference to the xvclk input clock
> > +- clock-names: shall be "xvclk"
>
> Could you add "clock-frequency" property here, please, and specify the
> upper and lower limits?
Can you also add the link-frequencies property, please?
--
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2019-08-13 11:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 9:22 [V1, 0/2] media: ov8856: DT bindings and sensor mode improvements dongchun.zhu
2019-08-08 9:22 ` [V1, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856 dongchun.zhu
2019-08-08 16:54 ` Sakari Ailus
2019-08-13 11:55 ` Sakari Ailus [this message]
2019-09-09 3:55 ` Dongchun Zhu
2019-08-08 9:22 ` [V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor dongchun.zhu
2019-08-08 13:53 ` Sakari Ailus
2019-09-09 8:46 ` Dongchun Zhu
2019-09-09 10:06 ` Sakari Ailus
2019-08-23 10:01 ` Tomasz Figa
2019-09-09 9:27 ` Dongchun Zhu
2019-09-10 13:23 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813115554.GA6133@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=ben.kao@intel.com \
--cc=bingbu.cao@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=shengnan.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).