From: Andrew Morton <akpm@linux-foundation.org>
To: Denis Efremov <efremov@ispras.ru>
Cc: Akinobu Mita <akinobu.mita@gmail.com>, Jan Kara <jack@suse.cz>,
Matthew Wilcox <matthew@wil.cx>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org,
Erdem Tumurov <erdemus@gmail.com>,
Vladimir Shelekhov <vshel@iis.nsk.su>
Subject: Re: [PATCH] lib/memweight.c: optimize by inlining bitmap_weight()
Date: Wed, 21 Aug 2019 18:25:07 -0700 [thread overview]
Message-ID: <20190821182507.b0dea16f57360cf0ac40deb6@linux-foundation.org> (raw)
In-Reply-To: <20190821074200.2203-1-efremov@ispras.ru>
On Wed, 21 Aug 2019 10:42:00 +0300 Denis Efremov <efremov@ispras.ru> wrote:
> This patch inlines bitmap_weight() call.
It is better to say the patch "open codes" the bitmap_weight() call.
> Thus, removing the BUG_ON,
Why is that OK to do?
I expect all the code size improvements are from doing this?
> and 'longs to bits -> bits to longs' conversion by directly calling
> hweight_long().
>
> ./scripts/bloat-o-meter lib/memweight.o.old lib/memweight.o.new
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-10 (-10)
> Function old new delta
> memweight 162 152 -10
>
next prev parent reply other threads:[~2019-08-22 1:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 7:42 [PATCH] lib/memweight.c: optimize by inlining bitmap_weight() Denis Efremov
2019-08-22 1:25 ` Andrew Morton [this message]
2019-08-22 7:30 ` Denis Efremov
2019-08-24 10:01 ` [PATCH v2] lib/memweight.c: open codes bitmap_weight() Denis Efremov
2019-08-25 6:11 ` Matthew Wilcox
2019-08-25 11:39 ` Denis Efremov
2019-08-26 18:39 ` Matthew Wilcox
2019-09-13 11:48 ` Denis Efremov
2019-09-13 13:41 ` efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821182507.b0dea16f57360cf0ac40deb6@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=akinobu.mita@gmail.com \
--cc=dm-devel@redhat.com \
--cc=efremov@ispras.ru \
--cc=erdemus@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=vshel@iis.nsk.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).