From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: linux-media@vger.kernel.org
Cc: dafna.hirschfeld@collabora.com, hverkuil@xs4all.nl,
dafna3@gmail.com, helen.koike@collabora.com,
ezequiel@collabora.com, skhan@linuxfoundation.org,
kernel@collabora.com
Subject: [PATCH v3 0/3] media: vimc: release vimc in release cb of v4l2_device
Date: Tue, 26 Nov 2019 13:08:19 +0100 [thread overview]
Message-ID: <20191126120822.11451-1-dafna.hirschfeld@collabora.com> (raw)
This patchset solves a crash that happens when unbinding the vimc
device while it is streaming. Currently when the device is unbounded
the vimc entities are released imidiettaly, this cause a crash
if the streaming thread or the capture device dereference them
after the release. The patchset solves this by deferring the release
to the release callback of v4l2_device. This ensures that
the vimc entities will be released after the last fh is closed
and so the streaming terminates before.
- The first patch replaces the usage of vimc_device.pdev.dev
with vimc.mdev.dev
- The second patch allocates the vimc_device dynamically.
This is needed since the release of the device is deferred
and might run after the device is initialized again.
- The third patch moves the release of the vimc_device
and all the vimc entities to the release callback of
v4l2_device.
Changes from v2:
in patch 3, in case of failure in the probe function the memory is released
directly from the probe function, and only on success path the release callback
of v4l2_device is assigned
Dafna Hirschfeld (3):
media: vimc: replace vimc->pdev.dev with vimc->mdev.dev
media: vimc: allocate vimc_device dynamically
media: vimc: crash fix - release vimc in the v4l_device release
drivers/media/platform/vimc/vimc-capture.c | 18 ++--
drivers/media/platform/vimc/vimc-common.c | 2 -
drivers/media/platform/vimc/vimc-common.h | 30 +++---
drivers/media/platform/vimc/vimc-core.c | 101 ++++++++++++++-------
drivers/media/platform/vimc/vimc-debayer.c | 19 ++--
drivers/media/platform/vimc/vimc-scaler.c | 19 ++--
drivers/media/platform/vimc/vimc-sensor.c | 18 ++--
7 files changed, 115 insertions(+), 92 deletions(-)
--
2.20.1
next reply other threads:[~2019-11-26 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 12:08 Dafna Hirschfeld [this message]
2019-11-26 12:08 ` [PATCH v3 1/3] media: vimc: replace vimc->pdev.dev with vimc->mdev.dev Dafna Hirschfeld
2019-11-26 12:08 ` [PATCH v3 2/3] media: vimc: allocate vimc_device dynamically Dafna Hirschfeld
2019-11-26 12:08 ` [PATCH v3 3/3] media: vimc: crash fix - release vimc in the v4l_device release Dafna Hirschfeld
2019-11-26 19:00 ` [PATCH v3 0/3] media: vimc: release vimc in release cb of v4l2_device Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126120822.11451-1-dafna.hirschfeld@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-media@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).