From: Sakari Ailus <sakari.ailus@iki.fi>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl, bingbu.cao@intel.com
Subject: Re: [PATCH 1/1] intel-ipu3: Align struct ipu3_uapi_awb_fr_config_s to 32 bytes
Date: Mon, 2 Dec 2019 10:47:21 +0200 [thread overview]
Message-ID: <20191202084720.GN833@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20191202083820.15639-1-sakari.ailus@linux.intel.com>
On Mon, Dec 02, 2019 at 10:38:20AM +0200, Sakari Ailus wrote:
> A struct that needs to be aligned to 32 bytes has a size of 28. Increase
> the size to 32.
>
> This makes elements of arrays of this struct aligned to 32 as well, and
> other structs where members are aligned to 32 mixing
> ipu3_uapi_awb_fr_config_s as well as other types.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Tested-by: Bingbu Cao <bingbu.cao@intel.com>
The tags should have included:
Fixes: commit dca5ef2aa1e6 ("media: staging/intel-ipu3: remove the unnecessary compiler flags")
> ---
> drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/ipu3/include/intel-ipu3.h b/drivers/staging/media/ipu3/include/intel-ipu3.h
> index 08eaa0bad0de..1c9c3ba4d518 100644
> --- a/drivers/staging/media/ipu3/include/intel-ipu3.h
> +++ b/drivers/staging/media/ipu3/include/intel-ipu3.h
> @@ -449,7 +449,7 @@ struct ipu3_uapi_awb_fr_config_s {
> __u16 reserved1;
> __u32 bayer_sign;
> __u8 bayer_nf;
> - __u8 reserved2[3];
> + __u8 reserved2[7];
> } __attribute__((aligned(32))) __packed;
>
> /**
> --
> 2.20.1
>
--
Sakari Ailus
prev parent reply other threads:[~2019-12-02 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 8:38 [PATCH 1/1] intel-ipu3: Align struct ipu3_uapi_awb_fr_config_s to 32 bytes Sakari Ailus
2019-12-02 8:47 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202084720.GN833@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=bingbu.cao@intel.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).