From: Marco Felsch <m.felsch@pengutronix.de>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
jacopo+renesas@jmondi.org, laurent.pinchart@ideasonboard.com,
kernel@pengutronix.de, hans.verkuil@cisco.com,
mchehab@kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v11 04/15] media: v4l2-fwnode: add initial connector parsing support
Date: Thu, 9 Jan 2020 08:07:08 +0100 [thread overview]
Message-ID: <20200109070708.arel6nepqs5ucl7b@pengutronix.de> (raw)
In-Reply-To: <20200108153626.we3zasacpriksczs@pengutronix.de>
Hi Sakari,
just a few questions about the below helper.
On 20-01-08 16:36, Marco Felsch wrote:
> Hi Sakari,
>
> On 19-11-16 01:34, Sakari Ailus wrote:
> > Hi Marco,
> >
> > On Mon, Sep 30, 2019 at 11:38:49AM +0200, Marco Felsch wrote:
>
> ...
>
> > > +int v4l2_fwnode_connector_alloc_parse(struct fwnode_handle *fwnode,
> > > + struct v4l2_fwnode_connector *connector)
> > > +{
> > > + struct fwnode_handle *remote_pp, *remote_ep;
> > > + const char *type_name;
> > > + unsigned int i = 0, ep_num = 0;
> > > + int err;
> > > +
> > > + memset(connector, 0, sizeof(*connector));
> > > +
> > > + remote_pp = fwnode_graph_get_remote_port_parent(fwnode);
> > > + if (!remote_pp)
> > > + return -ENOLINK;
>
> I will align the API with the v4l2_fwnode_endpoint_alloc_parse()
> function so the caller need to pass the connector fwnode handle.
Should we really align this with v4l2_fwnode_endpoint_alloc_parse()? I
have some concerns because this moves the step to the user. Using the
current approach makes it easier for the user.
Regards,
Marco
> > > +
> > > + /* Parse all common properties first. */
> > > + fwnode_graph_for_each_endpoint(remote_pp, remote_ep)
> > > + ep_num++;
> >
> > If there are no endpoints, ep_num will be zero and kmalloc_array() will
> > return NULL? There should be a way there are no endpoints, rather than
> > returning -ENOMEM.
> >
> > > +
> > > + connector->nr_of_links = ep_num;
> > > + connector->links = kmalloc_array(ep_num, sizeof(*connector->links),
> > > + GFP_KERNEL);
> > > + if (!connector->links) {
> > > + err = -ENOMEM;
> > > + goto err_put_fwnode;
> > > + }
> > > +
> > > + fwnode_graph_for_each_endpoint(remote_pp, remote_ep) {
> > > + err = v4l2_fwnode_parse_link(remote_ep, &connector->links[i]);
> >
> > If you start parsing a connector starting from another device connected to
> > it, nothing seems to prevent parsing the same links twice, in case the
> > connector is connected to more than one sub-device.
> >
> > Or do I miss something crucial here?
>
> Yes thats right but it seems that sharing connectors isn't supported at
> all. All bridge drivers using connectors implementing the connector
> handling by their self. Anyway, I will add a function parameter to check
> that we parse only the endpoints connected to the calling sub-dev.
>
> Regards,
> Marco
>
> > > + if (err) {
> > > + fwnode_handle_put(remote_ep);
> > > + goto err_free_links;
> > > + }
> > > + i++;
> > > + }
> > > +
> > > + /*
> > > + * Links reference counting guarantees access -> no duplication needed
> > > + */
> > > + fwnode_property_read_string(remote_pp, "label", &connector->label);
> > > +
> > > + /* The connector-type is stored within the compatible string. */
> > > + err = fwnode_property_read_string(remote_pp, "compatible", &type_name);
> > > + if (err) {
> > > + err = -EINVAL;
> > > + goto err_free_links;
> > > + }
> > > + connector->type = v4l2_fwnode_string_to_connector_type(type_name);
> > > +
> > > + /* Now parse the connector specific properties. */
> > > + switch (connector->type) {
> > > + case V4L2_CONN_COMPOSITE:
> > > + case V4L2_CONN_SVIDEO:
> > > + err = v4l2_fwnode_connector_parse_analog(remote_pp, connector);
> > > + break;
> > > + case V4L2_CONN_UNKNOWN:
> > > + default:
> > > + pr_err("Unknown connector type\n");
> > > + err = -EINVAL;
> > > + goto err_free_links;
> > > + }
> > > +
> > > + fwnode_handle_put(remote_pp);
> > > +
> > > + return err;
> > > +
> > > +err_free_links:
> > > + for (i = 0; i < ep_num; i++)
> > > + v4l2_fwnode_put_link(&connector->links[i]);
> > > + kfree(connector->links);
> > > +err_put_fwnode:
> > > + fwnode_handle_put(remote_pp);
> > > +
> > > + return err;
> > > +}
> > > +EXPORT_SYMBOL_GPL(v4l2_fwnode_connector_alloc_parse);
> > > +
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-01-09 7:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 9:38 [PATCH v11 00/15] TVP5150 Features and fixes Marco Felsch
2019-09-30 9:38 ` [PATCH v11 01/15] dt-bindings: connector: analog: add sdtv standards property Marco Felsch
2019-09-30 9:38 ` [PATCH v11 02/15] media: v4l: link dt-bindings and uapi Marco Felsch
2019-09-30 9:38 ` [PATCH v11 03/15] media: v4l2-fwnode: add v4l2_fwnode_connector Marco Felsch
2019-09-30 9:38 ` [PATCH v11 04/15] media: v4l2-fwnode: add initial connector parsing support Marco Felsch
2019-11-15 23:34 ` Sakari Ailus
2019-11-19 11:37 ` Marco Felsch
2019-11-27 8:17 ` Marco Felsch
2020-01-08 15:36 ` Marco Felsch
2020-01-09 7:07 ` Marco Felsch [this message]
2020-01-15 17:06 ` Marco Felsch
2020-02-18 12:18 ` Sakari Ailus
2019-09-30 9:38 ` [PATCH v11 05/15] partial revert of "[media] tvp5150: add HW input connectors support" Marco Felsch
2019-09-30 9:38 ` [PATCH v11 06/15] media: tvp5150: add input source selection of_graph support Marco Felsch
2019-09-30 9:38 ` [PATCH v11 07/15] media: dt-bindings: tvp5150: Add input port connectors DT bindings Marco Felsch
2019-09-30 9:38 ` [PATCH v11 08/15] media: tvp5150: fix set_selection rectangle handling Marco Felsch
2019-09-30 9:38 ` [PATCH v11 09/15] media: tvp5150: add FORMAT_TRY support for get/set selection handlers Marco Felsch
2019-09-30 9:38 ` [PATCH v11 10/15] media: tvp5150: initialize subdev before parsing device tree Marco Felsch
2019-09-30 9:38 ` [PATCH v11 11/15] media: tvp5150: add s_power callback Marco Felsch
2019-10-24 11:59 ` Sakari Ailus
2019-11-08 10:25 ` Marco Felsch
2019-11-08 10:38 ` Sakari Ailus
2019-09-30 9:38 ` [PATCH v11 12/15] media: dt-bindings: tvp5150: cleanup bindings stlye Marco Felsch
2019-09-30 9:38 ` [PATCH v11 13/15] media: dt-bindings: tvp5150: add optional sdtv standards documentation Marco Felsch
2019-09-30 9:38 ` [PATCH v11 14/15] media: tvp5150: add support to limit sdtv standards Marco Felsch
2019-09-30 9:39 ` [PATCH v11 15/15] media: tvp5150: make debug output more readable Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109070708.arel6nepqs5ucl7b@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).