From: Dan Carpenter <dan.carpenter@oracle.com>
To: Hillf Danton <hdanton@sina.com>
Cc: syzbot <syzbot+75287f75e2fedd69d680@syzkaller.appspotmail.com>,
andreyknvl@google.com, bnvandana@gmail.com,
hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-usb@vger.kernel.org, mchehab@kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: KASAN: use-after-free Read in v4l2_release (3)
Date: Fri, 24 Jan 2020 17:10:58 +0300 [thread overview]
Message-ID: <20200124141058.GM1847@kadam> (raw)
In-Reply-To: <20200123102707.2596-1-hdanton@sina.com>
This would work but another approach would be to to allocate "usbvision"
with devm_kzalloc(&dev->dev,... I believe that would postpone the free
enough to solve the use after free but I hadn't tested it yet. But
other drivers do that so hopefully it works.
regards,
dan carpenter
next prev parent reply other threads:[~2020-01-24 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 20:24 KASAN: use-after-free Read in v4l2_release (3) syzbot
2020-01-22 22:58 ` syzbot
[not found] ` <20200123102707.2596-1-hdanton@sina.com>
2020-01-23 12:19 ` Laurent Pinchart
[not found] ` <20200124022847.11244-1-hdanton@sina.com>
2020-01-24 12:41 ` Andrey Konovalov
2020-01-24 12:54 ` syzbot
2020-01-24 14:10 ` Dan Carpenter [this message]
2020-01-24 14:13 ` [PATCH] media: usbvision: Fix a use after free in v4l2_release() Dan Carpenter
2020-02-14 10:06 ` Hans Verkuil
2020-02-14 11:22 ` Laurent Pinchart
2020-02-14 11:30 ` Hans Verkuil
[not found] ` <20200214121447.13612-1-hdanton@sina.com>
2020-02-14 12:21 ` Hans Verkuil
[not found] ` <20200214124825.12568-1-hdanton@sina.com>
2020-02-14 13:34 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124141058.GM1847@kadam \
--to=dan.carpenter@oracle.com \
--cc=andreyknvl@google.com \
--cc=bnvandana@gmail.com \
--cc=hdanton@sina.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=syzbot+75287f75e2fedd69d680@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).