From: Patrik Gfeller <patrik.gfeller@gmail.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Francescodario Cuzzocrea
<francescodario.cuzzocrea@mail.polimi.it>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [GIT PULL] Ressurect the atomisp staging driver
Date: Mon, 4 May 2020 12:45:39 +0200 [thread overview]
Message-ID: <20200504124539.77eac397@ASUS> (raw)
In-Reply-To: <20200504104934.7873cee3@coco.lan>
On Mon, 4 May 2020 10:49:34 +0200
Mauro Carvalho Chehab <mchehab@kernel.org> wrote:
> Em Mon, 4 May 2020 10:16:28 +0200
> Patrik Gfeller <patrik.gfeller@gmail.com> escreveu:
>
> > On Sun, 3 May 2020 18:07:51 +0200
> > Patrik Gfeller <patrik.gfeller@gmail.com> wrote:
> >
> [...]
> >
> > I was not able yet to compile the kernel 4.4 successfully yet.
>
> Yesterday, I imported only a subset of the yocto patches. I imported today
> all 24 patches from it, as some patches depend on hacks on other upstream
> stuff. You'll need to do a:
>
> $ git remote update && git reset --hard origin/yocto_intel_atom
>
> To update your local branch.
>
> > I get quite
> > some warnings that are treated as errors. I assume that I can "resolve"
> > this by removing the respective compiler flag (-Werror).
>
> Yeah, you may need to to that. There's a Kernel option with disables
> -Werror. You may also change the Makefile to add things like:
>
> # HACK! While this driver is in bad shape, don't enable several warnings
> # that would be otherwise enabled with W=1
> ccflags-y += $(call cc-disable-warning, implicit-fallthrough)
> ccflags-y += $(call cc-disable-warning, missing-prototypes)
> ccflags-y += $(call cc-disable-warning, missing-declarations)
> ccflags-y += $(call cc-disable-warning, suggest-attribute=format)
> ccflags-y += $(call cc-disable-warning, unused-const-variable)
> ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
>
> (this is what we do with the upstream version, as this driver is on
> bad shape)
>
> > But there are a few things that will take more time for me to investigate:
> >
> > drivers/media/pci/atomisp//css2401a0_v21_build/../atomisp_driver/atomisp_cmd.c:36:10: fatal error: linux/kct.h: No such file or directory
> > include/media/v4l2-subdev.h:821:51: error: ‘const struct v4l2_subdev_core_ops’ has no member named ‘g_chip_ident’
> > include/media/v4l2-subdev.h:822:15: error: ‘const struct v4l2_subdev_core_ops’ has no member named ‘g_chip_ident’
There are still errors when I try to build. I've found code like the
one below:
const struct v4l2_ioctl_ops atomisp_ioctl_ops = {
.vidioc_querycap = atomisp_querycap,
#ifndef CONFIG_INTEL_MID_ISP
.vidioc_g_chip_ident = atomisp_g_chip_ident,
#endif
.vidioc_enum_input = atomisp_enum_input,
Therefore I've tried with "CONFIG_INTEL_MID_ISP=y". Not sure if this is
a good idea function wise - but it compiles. But the last step of the
module build produces some scary warnings:
WARNING: "cpu_tss" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
WARNING: "pv_lock_ops" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
WARNING: "__alloc_workqueue_key" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
WARNING: "v4l2_subdev_querymenu" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
WARNING: "intel_mid_msgbus_write32" [drivers/media/pci/atomisp//css2401a0_v21_build/atomisp-css2401a0_v21.ko] undefined!
...
Maybe this is related to my partial build (only the module to test if
it builds). I'll now do a full build of the kernel.
> >
> > I'll keep you updated.
>
> Maybe now with the other patches applied, this could have been solved.
>
> Thanks,
> Mauro
with kind regards,
Patrik
next prev parent reply other threads:[~2020-05-04 10:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 19:57 [GIT PULL] Ressurect the atomisp staging driver Mauro Carvalho Chehab
2020-05-02 6:03 ` Greg KH
2020-05-20 7:48 ` Mauro Carvalho Chehab
2020-05-03 9:19 ` Francescodario Cuzzocrea
2020-05-03 10:07 ` Mauro Carvalho Chehab
2020-05-03 15:32 ` Mauro Carvalho Chehab
[not found] ` <CADnVkj96W0QfthukTKQ0a-i2fH1buooH3BEgfy22J9H9=_PcKA@mail.gmail.com>
2020-05-03 16:07 ` Patrik Gfeller
2020-05-04 8:16 ` Patrik Gfeller
2020-05-04 8:49 ` Mauro Carvalho Chehab
2020-05-04 10:45 ` Patrik Gfeller [this message]
2020-05-04 12:08 ` Mauro Carvalho Chehab
2020-05-04 13:44 ` Patrik Gfeller
2020-05-15 8:32 ` Mauro Carvalho Chehab
2020-05-15 9:10 ` Hans de Goede
2020-05-15 9:42 ` Mauro Carvalho Chehab
2020-05-19 7:39 ` Mauro Carvalho Chehab
2020-05-19 17:36 ` Mauro Carvalho Chehab
2020-05-22 10:46 ` Hans de Goede
2020-05-22 11:42 ` Mauro Carvalho Chehab
2020-05-23 8:00 ` Mauro Carvalho Chehab
2020-05-27 16:23 ` Hans de Goede
2020-05-27 17:36 ` Mauro Carvalho Chehab
2020-05-15 9:37 ` Ressurect the atomisp staging driver - current progress Mauro Carvalho Chehab
2020-05-06 15:10 ` [GIT PULL] Ressurect the atomisp staging driver Mauro Carvalho Chehab
2020-05-03 9:23 ` bosconovic
2020-05-16 13:23 [GIT,PULL] " Finn Rayment
[not found] ` <20200516115459.4a24063b@coco.lan>
2020-05-16 19:53 ` Finn Rayment
2020-05-19 17:37 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504124539.77eac397@ASUS \
--to=patrik.gfeller@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=francescodario.cuzzocrea@mail.polimi.it \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).