From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Dan Scally <djrscally@gmail.com>,
gregkh@linuxfoundation.org, rafael@kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
heikki.krogerus@linux.intel.com, kieran.bingham@ideasonboard.com,
jorhand@linux.microsoft.com, kitakar@gmail.com
Subject: Re: [PATCH v2] software_node: Add support for fwnode_graph*() family of functions
Date: Fri, 18 Sep 2020 15:42:00 +0300 [thread overview]
Message-ID: <20200918124200.GY3956970@smile.fi.intel.com> (raw)
In-Reply-To: <20200918075741.GS834@valkosipuli.retiisi.org.uk>
On Fri, Sep 18, 2020 at 10:57:41AM +0300, Sakari Ailus wrote:
> On Fri, Sep 18, 2020 at 08:46:52AM +0100, Dan Scally wrote:
> > On 18/09/2020 08:34, Sakari Ailus wrote:
> > > On Fri, Sep 18, 2020 at 07:49:31AM +0100, Dan Scally wrote:
...
> > > The secondary field is there for this purpose. But it may be not all fwnode
> > > interface functions operate on fwnode->secondary?
> > Let me test it; it might just require some changes to
> > software_node_graph_get_port_parent() to check if the parent fwnode is a
> > secondary, and if it is to return the primary instead.
>
> Ah, indeed. I forgot this part. I wonder if it'd cause issues to return the
> primary if you've got the secondary swnode.
>
> Heikki, any idea?
>
> Code elsewhere (e.g. V4L2 fwnode framework + drivers) assume a device is
> identified by a single fwnode, not two --- currently the swnode graph
> function returning port parent returns the secondary so there's no match
> with the primary fwnode.
At least recently I made a patch (114dbb4fa7c4) to support secondary in
device_get_next_child_node(). I'm not sure how we can do it on fwnode level.
And now I'm thinking that above mentioned change is just particular case, but
doesn't really move entire device property API to that.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-09-18 12:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 23:28 [PATCH v2] software_node: Add support for fwnode_graph*() family of functions Daniel Scally
2020-09-16 9:17 ` Sakari Ailus
2020-09-16 13:22 ` Dan Scally
2020-09-16 14:32 ` Andy Shevchenko
2020-09-16 15:06 ` Kieran Bingham
2020-09-16 16:10 ` Andy Shevchenko
2020-09-18 6:22 ` Sakari Ailus
2020-09-18 6:49 ` Dan Scally
2020-09-18 7:34 ` Sakari Ailus
2020-09-18 7:46 ` Dan Scally
2020-09-18 7:57 ` Sakari Ailus
[not found] ` <20200918085709.GA1630537@kuha.fi.intel.com>
2020-09-18 9:10 ` Dan Scally
2020-09-18 9:15 ` Sakari Ailus
2020-09-18 9:22 ` Dan Scally
2020-09-18 12:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918124200.GY3956970@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jorhand@linux.microsoft.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=kitakar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).