From: Alexandre Courbot <acourbot@chromium.org>
To: Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, gnurou@gmail.com,
Alexandre Courbot <acourbot@chromium.org>
Subject: [PATCH v3 0/2] media: mtk-vcodec: fix builds when remoteproc is disabled
Date: Mon, 12 Oct 2020 14:35:55 +0900 [thread overview]
Message-ID: <20201012053557.4102148-1-acourbot@chromium.org> (raw)
Thanks everyone for the feedback on v2. This version has grown a little bit, but
most of the added lines is just code moving around to new files. All in all this
certainly makes the driver a little bit cleaner.
Tested on both MT8173 and MT8183 and confirmed that the decoder was working on
both.
Changes since v2:
* Use the FOO || !FOO magic suggested by Hans to ensure a built-in module does
not try to link against symbols in a module,
* Added a patch to split the VPU and SCP ops into their own source files and
make the optional build cleaner,
* Control the build of firmware implementations using two new transparent
Kconfig symbols.
Changes since v1:
* Added Acked-by from Randy.
* Fixed typo in Kconfig description.
Alexandre Courbot (2):
media: mtk-vcodec: move firmware implementations into their own files
media: mtk-vcodec: fix build breakage when one of VPU or SCP is
enabled
drivers/media/platform/Kconfig | 22 ++-
drivers/media/platform/mtk-vcodec/Makefile | 10 +-
.../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 2 +-
.../platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 2 +-
.../media/platform/mtk-vcodec/mtk_vcodec_fw.c | 174 +-----------------
.../media/platform/mtk-vcodec/mtk_vcodec_fw.h | 7 +-
.../platform/mtk-vcodec/mtk_vcodec_fw_priv.h | 52 ++++++
.../platform/mtk-vcodec/mtk_vcodec_fw_scp.c | 73 ++++++++
.../platform/mtk-vcodec/mtk_vcodec_fw_vpu.c | 109 +++++++++++
9 files changed, 274 insertions(+), 177 deletions(-)
create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_fw_priv.h
create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_fw_scp.c
create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_fw_vpu.c
--
2.28.0.1011.ga647a8990f-goog
next reply other threads:[~2020-10-12 5:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 5:35 Alexandre Courbot [this message]
2020-10-12 5:35 ` [PATCH v3 1/2] media: mtk-vcodec: move firmware implementations into their own files Alexandre Courbot
2020-10-12 5:35 ` [PATCH v3 2/2] media: mtk-vcodec: fix build breakage when one of VPU or SCP is enabled Alexandre Courbot
2020-10-12 7:43 ` Mauro Carvalho Chehab
2020-10-13 12:38 ` Alexandre Courbot
2020-10-12 14:59 ` Randy Dunlap
2020-10-13 0:57 ` Alexandre Courbot
2020-10-12 17:57 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012053557.4102148-1-acourbot@chromium.org \
--to=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=gnurou@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tiffany.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).