From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Daniel Scally <djrscally@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux.walleij@linaro.org,
prabhakar.mahadev-lad.rj@bp.renesas.com,
heikki.krogerus@linux.intel.com, dmitry.torokhov@gmail.com,
laurent.pinchart+renesas@ideasonboard.com,
kieran.bingham+renesas@ideasonboard.com,
jacopo+renesas@jmondi.org, robh@kernel.org, davem@davemloft.net,
linux@rasmusvillemoes.dk, andriy.shevchenko@linux.intel.com,
sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
pmladek@suse.com, mchehab@kernel.org, tian.shu.qiu@intel.com,
bingbu.cao@intel.com, yong.zhi@intel.com, rafael@kernel.org,
gregkh@linuxfoundation.org, kitakar@gmail.com,
dan.carpenter@oracle.org
Subject: Re: [RFC PATCH v3 4/9] software_node: Add support for fwnode_graph*() family of functions
Date: Tue, 20 Oct 2020 15:35:56 +0300 [thread overview]
Message-ID: <20201020123556.GW13341@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20201019225903.14276-5-djrscally@gmail.com>
Hi Daniel, Heikki,
Thanks for the patch.
On Mon, Oct 19, 2020 at 11:58:58PM +0100, Daniel Scally wrote:
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
> This implements the remaining .graph_* callbacks in the
> fwnode operations vector for the software nodes. That makes
> the fwnode_graph*() functions available in the drivers also
> when software nodes are used.
>
> The implementation tries to mimic the "OF graph" as much as
> possible, but there is no support for the "reg" device
> property. The ports will need to have the index in their
> name which starts with "port" (for example "port0", "port1",
> ...) and endpoints will use the index of the software node
> that is given to them during creation. The port nodes can
> also be grouped under a specially named "ports" subnode,
> just like in DT, if necessary.
>
> The remote-endpoints are reference properties under the
> endpoint nodes that are named "remote-endpoint".
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Co-developed-by: Daniel Scally <djrscally@gmail.com>
> Signed-off-by: Daniel Scally <djrscally@gmail.com>
> ---
> changes in v3:
> - removed software_node_device_is_available
> - moved the change to software_node_get_next_child to a separate
> patch
> - switched to use fwnode_handle_put() in graph_get_next_endpoint()
> instead of software_node_put()
>
> changes in v2:
> - added software_node_device_is_available
> - altered software_node_get_next_child to get references
> - altered software_node_get_next_endpoint to release references
> to ports and avoid passing invalid combinations of swnodes to
> software_node_get_next_child
> - altered swnode_graph_find_next_port to release port rather than
> old
> drivers/base/swnode.c | 120 +++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 119 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
> index 741149b90..3732530ce 100644
> --- a/drivers/base/swnode.c
> +++ b/drivers/base/swnode.c
> @@ -536,6 +536,120 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode,
> return 0;
> }
>
> +static struct fwnode_handle *
> +swnode_graph_find_next_port(const struct fwnode_handle *parent,
> + struct fwnode_handle *port)
> +{
> + struct fwnode_handle *old = port;
> +
> + while ((port = software_node_get_next_child(parent, old))) {
software_node_get_next_child() doesn't drop the reference of the old child
nor gets a reference to the returned node. Should it?
The function to get a named child node does.
It'd be nice if this was aligned. Or am I missing something?
This isn't really a comment on this patch though.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2020-10-20 12:36 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 22:58 [RFC PATCH v3 0/9] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows Daniel Scally
2020-10-19 22:58 ` [RFC PATCH v3 1/9] software_node: Add helper function to unregister arrays of software_nodes ordered parent to child Daniel Scally
2020-10-20 9:22 ` Andy Shevchenko
2020-10-20 10:05 ` Sakari Ailus
2020-10-20 11:01 ` Andy Shevchenko
2020-10-20 11:02 ` Andy Shevchenko
2020-10-20 11:04 ` Heikki Krogerus
2020-10-20 22:52 ` Dan Scally
2020-10-21 9:40 ` Andy Shevchenko
2020-10-21 9:54 ` Dan Scally
2020-10-19 22:58 ` [RFC PATCH v3 2/9] lib/test_printf.c: Use helper function to unwind array of software_nodes Daniel Scally
2020-10-20 7:23 ` Petr Mladek
2020-10-20 9:20 ` Andy Shevchenko
2020-10-19 22:58 ` [RFC PATCH v3 3/9] software_node: Fix failure to hold refcount in software_node_get_next_child Daniel Scally
2020-10-20 12:44 ` Rafael J. Wysocki
2020-10-20 13:31 ` Sakari Ailus
2020-10-20 23:25 ` Dan Scally
2020-10-21 9:33 ` Andy Shevchenko
2020-10-21 9:37 ` Sakari Ailus
2020-10-21 9:56 ` Dan Scally
2020-10-19 22:58 ` [RFC PATCH v3 4/9] software_node: Add support for fwnode_graph*() family of functions Daniel Scally
2020-10-20 9:17 ` Andy Shevchenko
2020-10-20 12:35 ` Sakari Ailus [this message]
2020-10-20 13:32 ` Sakari Ailus
2020-10-19 22:58 ` [RFC PATCH v3 5/9] ipu3-cio2: Add T: entry to MAINTAINERS Daniel Scally
2020-10-20 9:16 ` Andy Shevchenko
2020-10-24 0:28 ` Laurent Pinchart
2020-10-19 22:59 ` [RFC PATCH v3 6/9] ipu3-cio2: Rename ipu3-cio2.c to allow module to be built from multiple sources files retaining ipu3-cio2 name Daniel Scally
2020-10-20 9:15 ` Andy Shevchenko
2020-10-20 20:41 ` Dan Scally
2020-10-24 0:34 ` Laurent Pinchart
2020-10-19 22:59 ` [RFC PATCH v3 7/9] ipu3-cio2: Check if pci_dev->dev's fwnode is a software_node in cio2_parse_firmware() and set FWNODE_GRAPH_DEVICE_DISABLED if so Daniel Scally
2020-10-20 9:19 ` Andy Shevchenko
2020-10-20 12:06 ` Sakari Ailus
2020-10-20 19:56 ` Dan Scally
2020-10-20 22:49 ` Sakari Ailus
2020-10-20 22:55 ` Dan Scally
2020-10-24 0:39 ` Laurent Pinchart
2020-10-24 14:29 ` Sakari Ailus
2020-10-24 16:33 ` Dan Scally
2020-10-24 16:55 ` Laurent Pinchart
2020-10-19 22:59 ` [RFC PATCH v3 8/9] media: v4l2-core: v4l2-async: Check possible match in match_fwnode based on sd->fwnode->secondary Daniel Scally
2020-10-19 22:59 ` [RFC PATCH v3 9/9] ipu3-cio2: Add functionality allowing software_node connections to sensors on platforms designed for Windows Daniel Scally
2020-10-20 9:41 ` Andy Shevchenko
2020-10-21 22:05 ` Daniel Scally
2020-10-22 13:40 ` Andy Shevchenko
2020-10-23 10:06 ` Dan Scally
2020-10-24 1:24 ` Laurent Pinchart
2020-10-24 8:50 ` Dan Scally
2020-10-24 9:37 ` Laurent Pinchart
2020-10-24 22:28 ` Daniel Scally
2020-10-24 22:36 ` Laurent Pinchart
2020-10-24 22:50 ` Daniel Scally
2020-10-26 8:20 ` Dan Scally
2020-10-26 16:05 ` Andy Shevchenko
2020-10-29 20:17 ` Laurent Pinchart
2020-10-29 22:36 ` Dan Scally
2020-10-26 16:10 ` Andy Shevchenko
2020-10-29 20:19 ` Laurent Pinchart
2020-10-29 20:26 ` Andy Shevchenko
2020-10-29 21:29 ` Laurent Pinchart
2020-10-29 22:22 ` Andy Shevchenko
2020-10-29 22:51 ` Laurent Pinchart
2020-11-13 10:02 ` Dan Scally
2020-11-13 16:22 ` Laurent Pinchart
2020-11-13 19:45 ` Andy Shevchenko
2020-11-15 8:45 ` Daniel Scally
2020-11-16 8:53 ` Laurent Pinchart
2020-11-16 13:57 ` Andy Shevchenko
2020-11-16 14:10 ` Laurent Pinchart
2020-11-16 14:15 ` Dan Scally
2020-11-16 16:16 ` Andy Shevchenko
2020-11-17 12:01 ` Dan Scally
2020-11-17 16:42 ` Andy Shevchenko
2020-11-17 22:59 ` Dan Scally
2020-10-24 15:11 ` Sakari Ailus
2020-10-24 15:14 ` Sakari Ailus
2020-10-24 20:28 ` Dan Scally
2020-10-25 11:18 ` Sakari Ailus
2020-10-20 9:24 ` [RFC PATCH v3 0/9] Add functionality to ipu3-cio2 driver " Andy Shevchenko
2020-10-20 13:38 ` Rafael J. Wysocki
2020-10-21 20:59 ` Daniel Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020123556.GW13341@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=dan.carpenter@oracle.org \
--cc=davem@davemloft.net \
--cc=djrscally@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kitakar@gmail.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux.walleij@linaro.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mchehab@kernel.org \
--cc=pmladek@suse.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).