From: Deepak R Varma <mh12gx2825@gmail.com>
To: outreachy-kernel@googlegroups.com,
Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v5 1/2] staging: media: imx: remove commented code
Date: Mon, 26 Oct 2020 09:30:17 +0530 [thread overview]
Message-ID: <20201026040017.GA5074@my--box> (raw)
In-Reply-To: <9fd1e7dd9e8f944b520f2a789e66e458aeb7b555.1602869338.git.mh12gx2825@gmail.com>
On Fri, Oct 16, 2020 at 11:10:33PM +0530, Deepak R Varma wrote:
Hello All,
Request for review / ack of this patch.
Thank you.
Deepak.
> The virtual channel is always treated as 0 once the stream enters
> CSI's. Commented code in the "#if 0" can be safely removed as it will
> not serve any purpose in future. Issue reported by checkpatch script.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> Changes since v4:
> - Rephrase patch description to make it exact and accurate as
> suggested by Julia.
> - Add linux-media to the recipient list. Suggested by Hans.
> Changes since v3:
> - Rephrase Patch description
> - Implement feedback from Vaishali & Helen to mention checkpatch in
> the patch description.
> Changes since v2:
> - None
> Changes since v1:
> - Implement feedback from Julia to be exact with the patch description
>
> drivers/staging/media/imx/imx-media-csi.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 21ebf7769696..9320e3974d86 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -1131,13 +1131,6 @@ static int csi_link_validate(struct v4l2_subdev *sd,
> * enters the CSI's however, they are treated internally
> * in the IPU as virtual channel 0.
> */
> -#if 0
> - mutex_unlock(&priv->lock);
> - vc_num = imx_media_find_mipi_csi2_channel(&priv->sd.entity);
> - if (vc_num < 0)
> - return vc_num;
> - mutex_lock(&priv->lock);
> -#endif
> ipu_csi_set_mipi_datatype(priv->csi, vc_num,
> &priv->format_mbus[CSI_SINK_PAD]);
> }
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-10-26 4:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 17:40 [PATCH v5 1/2] staging: media: imx: remove commented code Deepak R Varma
2020-10-16 17:43 ` Steve Longerbeam
2020-10-16 17:46 ` [PATCH 2/2 v5] staging: media: imx: remove unnecessary variable use Deepak R Varma
2020-10-16 17:46 ` Steve Longerbeam
2020-10-26 4:02 ` Deepak R Varma
2020-10-26 4:00 ` Deepak R Varma [this message]
2020-10-26 5:56 ` [PATCH v5 1/2] staging: media: imx: remove commented code Greg Kroah-Hartman
2020-10-26 18:03 ` Deepak R Varma
2020-10-27 9:43 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026040017.GA5074@my--box \
--to=mh12gx2825@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).