From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB4DC433E9 for ; Mon, 28 Dec 2020 17:48:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B36B122B2B for ; Mon, 28 Dec 2020 17:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728491AbgL1Rsk (ORCPT ); Mon, 28 Dec 2020 12:48:40 -0500 Received: from mga07.intel.com ([134.134.136.100]:44521 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728427AbgL1Rsk (ORCPT ); Mon, 28 Dec 2020 12:48:40 -0500 IronPort-SDR: JUBcfNaynn90dzJ4Z1+hZsZ2cbz1a+Nv8TT77eEHNswQ/BRXcf0N76M+NHYlvDkZShVrkPlQh7 q2uxUpRLW8Lg== X-IronPort-AV: E=McAfee;i="6000,8403,9848"; a="240490238" X-IronPort-AV: E=Sophos;i="5.78,455,1599548400"; d="scan'208";a="240490238" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2020 09:46:49 -0800 IronPort-SDR: F+iePjSvC28UpUOwdS5NapmwvWE+JcaV0lCEZJDdxqB+CSty7Qzz3h/ul22bRfZO9ik3EDRgPB aKS+8OlTJvPQ== X-IronPort-AV: E=Sophos;i="5.78,455,1599548400"; d="scan'208";a="392834104" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2020 09:46:43 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1ktwcS-000GAJ-9c; Mon, 28 Dec 2020 19:47:44 +0200 Date: Mon, 28 Dec 2020 19:47:44 +0200 From: Andy Shevchenko To: Sakari Ailus Cc: Daniel Scally , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-media@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net, lenb@kernel.org, gregkh@linuxfoundation.org, yong.zhi@intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, robert.moore@intel.com, erik.kaneda@intel.com, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, linux@rasmusvillemoes.dk, laurent.pinchart+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, hverkuil-cisco@xs4all.nl, m.felsch@pengutronix.de, niklas.soderlund+renesas@ragnatech.se, slongerbeam@gmail.com, heikki.krogerus@linux.intel.com, linus.walleij@linaro.org, kernel test robot , Dan Carpenter , Laurent Pinchart Subject: Re: [PATCH v3 05/14] software_node: unregister software_nodes in reverse order Message-ID: <20201228174744.GB4077@smile.fi.intel.com> References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-6-djrscally@gmail.com> <20201228163410.GX26370@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201228163410.GX26370@paasikivi.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Dec 28, 2020 at 06:34:10PM +0200, Sakari Ailus wrote: > On Thu, Dec 24, 2020 at 01:08:58AM +0000, Daniel Scally wrote: ... > > void software_node_unregister_node_group(const struct software_node **node_group) > > With this line wrapped, Why? It's only one character behind 80 and wrapping it will decrease readability. Moreover, documentation has explicit exceptions for such cases. -- With Best Regards, Andy Shevchenko