From: kernel test robot <lkp@intel.com>
To: Heiko Stuebner <heiko@sntech.de>,
dafna.hirschfeld@collabora.com, helen.koike@collabora.com,
linux-media@vger.kernel.org, mchehab@kernel.org,
Laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl
Cc: kbuild-all@lists.01.org, linux-rockchip@lists.infradead.org,
ezequiel@collabora.com, christoph.muellner@theobroma-systems.com,
heiko@sntech.de
Subject: Re: [PATCH v2 2/2] media: rockchip: rkisp1: extend uapi array sizes
Date: Fri, 15 Jan 2021 15:44:44 +0800 [thread overview]
Message-ID: <202101151534.sxHFCw3R-lkp@intel.com> (raw)
In-Reply-To: <20210114233345.160223-3-heiko@sntech.de>
[-- Attachment #1: Type: text/plain, Size: 2711 bytes --]
Hi Heiko,
I love your patch! Perhaps something to improve:
[auto build test WARNING on rockchip/for-next]
[also build test WARNING on linuxtv-media/master linus/master v5.11-rc3 next-20210114]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Heiko-Stuebner/media-rockchip-rkisp1-carry-ip-version-information/20210115-124728
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9a078d10ec53e5c1651ed5da0b37b0e4eb34fc47
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Heiko-Stuebner/media-rockchip-rkisp1-carry-ip-version-information/20210115-124728
git checkout 9a078d10ec53e5c1651ed5da0b37b0e4eb34fc47
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c: In function 'rkisp1_stats_get_hst_meas':
>> drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c:239:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
239 | memset(pbuf->params.hist.hist_bins, 0, RKISP1_CIF_ISP_HIST_BIN_N_MAX);
| ^~~~~~
vim +/memset +239 drivers/media/platform/rockchip/rkisp1/rkisp1-stats.c
231
232 static void rkisp1_stats_get_hst_meas(struct rkisp1_stats *stats,
233 struct rkisp1_stat_buffer *pbuf)
234 {
235 struct rkisp1_device *rkisp1 = stats->rkisp1;
236 unsigned int i;
237
238 /* the global max can be bigger then the version-specific one */
> 239 memset(pbuf->params.hist.hist_bins, 0, RKISP1_CIF_ISP_HIST_BIN_N_MAX);
240
241 pbuf->meas_type |= RKISP1_CIF_ISP_STAT_HIST;
242 for (i = 0; i < RKISP1_CIF_ISP_HIST_BIN_N_MAX_V10; i++)
243 pbuf->params.hist.hist_bins[i] =
244 (u8)rkisp1_read(rkisp1,
245 RKISP1_CIF_ISP_HIST_BIN_0 + i * 4);
246 }
247
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55188 bytes --]
next prev parent reply other threads:[~2021-01-15 7:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 23:33 [PATCH v2 0/2] Fix the rkisp1 userspace API for later IP versions Heiko Stuebner
2021-01-14 23:33 ` [PATCH v2 1/2] media: rockchip: rkisp1: carry ip version information Heiko Stuebner
2021-01-14 23:33 ` [PATCH v2 2/2] media: rockchip: rkisp1: extend uapi array sizes Heiko Stuebner
2021-01-15 7:44 ` kernel test robot [this message]
2021-01-15 8:10 ` kernel test robot
2021-01-14 23:33 ` [PATCH 0/2] Fix the rkisp1 userspace API for later IP versions Heiko Stuebner
2021-01-14 23:35 ` Heiko Stübner
2021-01-14 23:33 ` [PATCH 1/2] media: rockchip: rkisp1: carry ip version information Heiko Stuebner
2021-01-14 23:33 ` [PATCH 2/2] media: rockchip: rkisp1: extend uapi array sizes Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101151534.sxHFCw3R-lkp@intel.com \
--to=lkp@intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kbuild-all@lists.01.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).