Re: [PATCH v6 10/14] media: imx: imx8q: implement windsor encoder rpc interface

From: kernel test robot <lkp@intel.com>
To: Ming Qian <ming.qian@nxp.com>,
	mchehab@kernel.org, shawnguo@kernel.org, robh+dt@kernel.org,
	s.hauer@pengutronix.de
Cc: kbuild-all@lists.01.org, hverkuil-cisco@xs4all.nl,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	aisheng.dong@nxp.com, linux-media@vger.kernel.org
Subject: Re: [PATCH v6 10/14] media: imx: imx8q: implement windsor encoder rpc interface
Date: Wed, 11 Aug 2021 22:55:22 +0800	[thread overview]
Message-ID: <202108112231.Xw1NV5t8-lkp@intel.com> (raw)
In-Reply-To: <aa51962b851fe8d0d7cafe6f13b5a2141010bacc.1628671163.git.ming.qian@nxp.com>

[-- Attachment #1: Type: text/plain, Size: 2768 bytes --]

Hi Ming,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on robh/for-next v5.14-rc5]
[cannot apply to shawnguo/for-next next-20210811]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ming-Qian/imx8q-video-decoder-encoder-driver/20210811-164741
base:   git://linuxtv.org/media_tree.git master
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/24cb9d25f8f3e58921074286fe42eedc10aa1214
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ming-Qian/imx8q-video-decoder-encoder-driver/20210811-164741
        git checkout 24cb9d25f8f3e58921074286fe42eedc10aa1214
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/media/platform/imx/vpu-8q/vpu_imx8q.c:139:5: warning: no previous prototype for 'vpu_imx8q_get_fuse' [-Wmissing-prototypes]
     139 | u32 vpu_imx8q_get_fuse(void)
         |     ^~~~~~~~~~~~~~~~~~

vim +/vpu_imx8q_get_fuse +139 drivers/media/platform/imx/vpu-8q/vpu_imx8q.c

   137	
   138	#ifdef CONFIG_IMX_SCU
 > 139	u32 vpu_imx8q_get_fuse(void)
   140	{
   141		static u32 fuse_got;
   142		struct imx_sc_ipc *ipc;
   143		struct vpu_sc_msg_misc msg;
   144		struct imx_sc_rpc_msg *hdr = &msg.hdr;
   145		int ret;
   146	
   147		if (fuse_got)
   148			return imx8q_fuse;
   149	
   150		ret = imx_scu_get_handle(&ipc);
   151		if (ret) {
   152			vpu_err("error: scu get handle fail: %d\n", ret);
   153			return 0;
   154		}
   155	
   156		hdr->ver = IMX_SC_RPC_VERSION;
   157		hdr->svc = IMX_SC_RPC_SVC_MISC;
   158		hdr->func = IMX_SC_MISC_FUNC_OTP_FUSE_READ;
   159		hdr->size = 2;
   160	
   161		msg.word = VPU_DISABLE_BITS;
   162	
   163		ret = imx_scu_call_rpc(ipc, &msg, true);
   164		if (ret)
   165			return 0;
   166	
   167		imx8q_fuse = msg.word;
   168		fuse_got = 1;
   169		vpu_dbg(LVL_INFO, "imx8q fuse = 0x%x\n", imx8q_fuse);
   170		return imx8q_fuse;
   171	}
   172	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 77932 bytes --]