From: Jacopo Mondi <jacopo@jmondi.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: laurent.pinchart@ideasonboard.com, hverkuil-cisco@xs4all.nl,
linux-media@vger.kernel.org, jacopo+renesas@jmondi.org,
morimoto.kuninori@renesas.com
Subject: Re: [RFC 2/3] media: tw9910: Allow the TW9990 to probe
Date: Mon, 13 Sep 2021 11:00:41 +0200 [thread overview]
Message-ID: <20210913090041.zqj4wsnli5dmnkv6@uno.localdomain> (raw)
In-Reply-To: <20210827130150.909695-2-festevam@gmail.com>
Hi Fabio,
On Fri, Aug 27, 2021 at 10:01:49AM -0300, Fabio Estevam wrote:
> Currently the driver rejects to probe when the ID is
> different from the TW9910 one.
>
> Allow TW9990 to probe by allowing its ID too.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/media/i2c/tw9910.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c
> index 04f3c2dbc1cc..0411b8ea9bda 100644
> --- a/drivers/media/i2c/tw9910.c
> +++ b/drivers/media/i2c/tw9910.c
> @@ -859,7 +859,7 @@ static int tw9910_video_probe(struct i2c_client *client)
> priv->revision = GET_REV(id);
> id = GET_ID(id);
>
> - if (id != 0x0b || priv->revision > 0x01) {
> + if ((id != 0x0b && id != 0x00) || priv->revision > 0x01) {
I would define these. Up to you!
> dev_err(&client->dev, "Product ID error %x:%x\n",
> id, priv->revision);
> ret = -ENODEV;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-09-13 8:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 13:01 [RFC 1/3] media: tw9910: Allow to probe from device tree Fabio Estevam
2021-08-27 13:01 ` [RFC 2/3] media: tw9910: Allow the TW9990 to probe Fabio Estevam
2021-09-13 9:00 ` Jacopo Mondi [this message]
2021-08-27 13:01 ` [RFC 3/3] media: tw9910: Initialize the entity type Fabio Estevam
2021-09-13 9:06 ` Jacopo Mondi
2021-08-28 13:58 ` [RFC 1/3] media: tw9910: Allow to probe from device tree Fabio Estevam
2021-09-13 8:59 ` Jacopo Mondi
2021-09-13 12:53 ` Fabio Estevam
2021-09-13 20:03 ` Fabio Estevam
2021-09-13 22:12 ` Rui Miguel Silva
2021-09-16 20:52 ` Fabio Estevam
2021-09-16 22:05 ` Rui Miguel Silva
2021-09-17 3:28 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913090041.zqj4wsnli5dmnkv6@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=morimoto.kuninori@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).